Re: [Qemu-devel] [PATCH for-2.12 v3 02/11] ppc/xics: remove useless if condition

2017-11-12 Thread David Gibson
On Fri, Nov 10, 2017 at 03:20:08PM +, Cédric Le Goater wrote: > The previous code section uses a 'first < 0' test and returns. Therefore, > there is no need to test the 'first' variable against '>= 0' afterwards. > > Signed-off-by: Cédric Le Goater > --- > hw/intc/xics_spapr.c | 6 ++ >

Re: [Qemu-devel] [PATCH for-2.12 v3 02/11] ppc/xics: remove useless if condition

2017-11-11 Thread Greg Kurz
On Fri, 10 Nov 2017 15:20:08 + Cédric Le Goater wrote: > The previous code section uses a 'first < 0' test and returns. Therefore, > there is no need to test the 'first' variable against '>= 0' afterwards. > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > hw/intc/xics_s

[Qemu-devel] [PATCH for-2.12 v3 02/11] ppc/xics: remove useless if condition

2017-11-10 Thread Cédric Le Goater
The previous code section uses a 'first < 0' test and returns. Therefore, there is no need to test the 'first' variable against '>= 0' afterwards. Signed-off-by: Cédric Le Goater --- hw/intc/xics_spapr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/intc/xics_spapr