Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-25 Thread Markus Armbruster
Superseded by [PATCH v2 for-2.3 0/5] Contain drive, serial, parallel, net misuse

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-25 Thread Markus Armbruster
Markus Armbruster writes: [...] > * "allwinner-a10" > >"-nodefaults -serial null -device allwinner-a10" doesn't explode, >which means I can't exclude the possibility that this might actually >do something useful for someone. I'd say we treat it just like >"pc87312": leave alone n

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 21:03, Markus Armbruster wrote: > * Of the sysbus devices only "xlnx.xps-uartlite" seems to be available > with the machines that support -device for sysbus devices (ppce500 and > pseries-*). When I try to -device it there, I get "Device > xlnx.xps-uartlite is not supported b

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Markus Armbruster
Paolo Bonzini writes: >> I really can't see why we should tie ourselves into knots to avoid an >> incompatible change here. I seriously doubt anyone will notice if drop >> the mistaken automatic backend pickup so that "-drive if=floppy -device >> i82378 -device pc87312" no longer picks up the fl

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
> I really can't see why we should tie ourselves into knots to avoid an > incompatible change here. I seriously doubt anyone will notice if drop > the mistaken automatic backend pickup so that "-drive if=floppy -device > i82378 -device pc87312" no longer picks up the floppy. Ok, it wasn't too har

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 24/03/2015 13:48, Markus Armbruster wrote: >> Use of -drive if=floppy with onboard pc87312 (machine "prep") shouldn't >> be affected. Likewise for connecting onboard m25p80-generic derivatives >> with if=mtd drives, or onboard ssi-sd with if=sd. > > Exactly. > >> Weird

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
On 24/03/2015 13:48, Markus Armbruster wrote: > Use of -drive if=floppy with onboard pc87312 (machine "prep") shouldn't > be affected. Likewise for connecting onboard m25p80-generic derivatives > with if=mtd drives, or onboard ssi-sd with if=sd. Exactly. > Weird usage similar to the one you ca

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Markus Armbruster
Adding Andreas because he's the odd fixer for pc87312. Paolo Bonzini writes: > On 23/03/2015 20:09, Markus Armbruster wrote: >> Drives defined with if!=none are for board initialization to wire up. >> Board code calls drive_get() or similar to find them, and creates >> devices with their qdev dr

Re: [Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-24 Thread Paolo Bonzini
On 23/03/2015 20:09, Markus Armbruster wrote: > Drives defined with if!=none are for board initialization to wire up. > Board code calls drive_get() or similar to find them, and creates > devices with their qdev drive properties set accordingly. > > Except a few devices go on a fishing expeditio

[Qemu-devel] [PATCH for-2.3 0/3] Contain drive_get() misuse

2015-03-23 Thread Markus Armbruster
Drives defined with if!=none are for board initialization to wire up. Board code calls drive_get() or similar to find them, and creates devices with their qdev drive properties set accordingly. Except a few devices go on a fishing expedition for a suitable backend instead of exposing a drive prope