Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-08-05 Thread Daniel P. Berrange
On Fri, Jul 31, 2015 at 07:58:45PM +0200, Stefan Weil wrote: > Am 31.07.2015 um 14:49 schrieb Paolo Bonzini: > >On 31/07/2015 12:17, Daniel P. Berrange wrote: > >> CCutil/osdep.o > >>In file included from include/qemu-common.h:48:0, > >> from util/osdep.c:48: > >>include/syse

Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-07-31 Thread Stefan Weil
Am 31.07.2015 um 14:49 schrieb Paolo Bonzini: On 31/07/2015 12:17, Daniel P. Berrange wrote: CCutil/osdep.o In file included from include/qemu-common.h:48:0, from util/osdep.c:48: include/sysemu/os-win32.h:77:12: error: redundant redeclaration of 'gmtime_r' [-Werror=red

Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-07-31 Thread Daniel P. Berrange
On Fri, Jul 31, 2015 at 02:49:49PM +0200, Paolo Bonzini wrote: > > > On 31/07/2015 12:17, Daniel P. Berrange wrote: > > > > CCutil/osdep.o > > In file included from include/qemu-common.h:48:0, > > from util/osdep.c:48: > > include/sysemu/os-win32.h:77:12: error: redundant

Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-07-31 Thread Paolo Bonzini
On 31/07/2015 12:17, Daniel P. Berrange wrote: > > CCutil/osdep.o > In file included from include/qemu-common.h:48:0, > from util/osdep.c:48: > include/sysemu/os-win32.h:77:12: error: redundant redeclaration of 'gmtime_r' > [-Werror=redundant-decls] > struct tm *gmtime_r

[Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing

2015-07-31 Thread Daniel P. Berrange
The oslib-win32 file currently provides a localtime_r and gmtime_r replacement unconditionally. Some versions of Mingw64 would provide crude macros for localtime_r/gmtime_r which QEMU takes care to disable. Latest versions of Mingw64 now provide actual functions for localtime_r/gmtime_r, but with a