Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 13:23, Michael S. Tsirkin wrote: > On Mon, Jul 13, 2015 at 12:18:31PM +0200, Paolo Bonzini wrote: >> >> >> On 13/07/2015 11:01, Cornelia Huck wrote: >>> On Thu, 9 Jul 2015 13:01:14 +0200 >>> Cornelia Huck wrote: >>> 64 bit props used 32 bit callbacks in two places, leading to

Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 12:18:31PM +0200, Paolo Bonzini wrote: > > > On 13/07/2015 11:01, Cornelia Huck wrote: > > On Thu, 9 Jul 2015 13:01:14 +0200 > > Cornelia Huck wrote: > > > >> 64 bit props used 32 bit callbacks in two places, leading to broken > >> feature bits on virtio (example: got 0

Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 11:01, Cornelia Huck wrote: > On Thu, 9 Jul 2015 13:01:14 +0200 > Cornelia Huck wrote: > >> 64 bit props used 32 bit callbacks in two places, leading to broken >> feature bits on virtio (example: got 0x310006d4 which is >> obviously bogus). Fix this. >> >> Fixes: fdba6d96

Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties

2015-07-13 Thread Cornelia Huck
On Thu, 9 Jul 2015 13:01:14 +0200 Cornelia Huck wrote: > 64 bit props used 32 bit callbacks in two places, leading to broken > feature bits on virtio (example: got 0x310006d4 which is > obviously bogus). Fix this. > > Fixes: fdba6d96 ("qdev: add 64bit properties") > Signed-off-by: Corne

Re: [Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties

2015-07-09 Thread Christian Borntraeger
Am 09.07.2015 um 13:01 schrieb Cornelia Huck: > 64 bit props used 32 bit callbacks in two places, leading to broken > feature bits on virtio (example: got 0x310006d4 which is > obviously bogus). Fix this. > > Fixes: fdba6d96 ("qdev: add 64bit properties") > Signed-off-by: Cornelia Huck T

[Qemu-devel] [PATCH for-2.4] qdev: fix 64 bit properties

2015-07-09 Thread Cornelia Huck
64 bit props used 32 bit callbacks in two places, leading to broken feature bits on virtio (example: got 0x310006d4 which is obviously bogus). Fix this. Fixes: fdba6d96 ("qdev: add 64bit properties") Signed-off-by: Cornelia Huck --- hw/core/qdev-properties.c| 2 +- include/hw/qdev-pr