Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant

2015-07-26 Thread Aurelien Jarno
On 2015-07-25 16:12, Richard Henderson wrote: > On 07/25/2015 03:51 PM, Aurelien Jarno wrote: > >On 2015-07-25 15:06, Richard Henderson wrote: > >>On 07/24/2015 04:34 PM, Aurelien Jarno wrote: > >>> ots->val_type = TEMP_VAL_CONST; > >>> ots->val = ts->val; > >>>+if (IS_DEA

Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant

2015-07-25 Thread Richard Henderson
On 07/25/2015 03:51 PM, Aurelien Jarno wrote: On 2015-07-25 15:06, Richard Henderson wrote: On 07/24/2015 04:34 PM, Aurelien Jarno wrote: ots->val_type = TEMP_VAL_CONST; ots->val = ts->val; +if (IS_DEAD_ARG(1)) { +temp_dead(s, args[1]); +} Aren'

Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant

2015-07-25 Thread Aurelien Jarno
On 2015-07-25 15:06, Richard Henderson wrote: > On 07/24/2015 04:34 PM, Aurelien Jarno wrote: > > ots->val_type = TEMP_VAL_CONST; > > ots->val = ts->val; > >+if (IS_DEAD_ARG(1)) { > >+temp_dead(s, args[1]); > >+} > > Aren't we also missing > > if (N

Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant

2015-07-25 Thread Richard Henderson
On 07/24/2015 04:34 PM, Aurelien Jarno wrote: ots->val_type = TEMP_VAL_CONST; ots->val = ts->val; +if (IS_DEAD_ARG(1)) { +temp_dead(s, args[1]); +} Aren't we also missing if (NEED_SYNC_ARG(0)) { temp_sync(s, args[0], allocated_regs); } a

[Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant

2015-07-24 Thread Aurelien Jarno
When tcg_reg_alloc_mov propagate a constant, we failed to correctly mark a temp as dead if the liveness analysis hints so. This fixes the following assert when configure with --enable-debug-tcg: qemu-x86_64: tcg/tcg.c:1827: tcg_reg_alloc_bb_end: Assertion `ts->val_type == TEMP_VAL_DEAD' failed.