Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-15 Thread Fam Zheng
On Wed, 07/15 15:38, Jason Wang wrote: > > > On 07/15/2015 02:01 PM, Fam Zheng wrote: > > On Wed, 07/15 13:10, Jason Wang wrote: > And can we do this without a bh? Otherwise, we may need to stop and > restart the bh during vm stop and start? > >>> A bh doesn't hurt when vm stop and rest

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-15 Thread Jason Wang
On 07/15/2015 02:01 PM, Fam Zheng wrote: > On Wed, 07/15 13:10, Jason Wang wrote: And can we do this without a bh? Otherwise, we may need to stop and restart the bh during vm stop and start? >>> A bh doesn't hurt when vm stop and restart (we get superfluous flush), >> The problem is qem

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-14 Thread Fam Zheng
On Wed, 07/15 13:10, Jason Wang wrote: > >> And can we do this without a bh? Otherwise, we may need to stop and > >> restart the bh during vm stop and start? > > A bh doesn't hurt when vm stop and restart (we get superfluous flush), > > The problem is qemu_flush_queued_packets() does not check run

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-14 Thread Jason Wang
On 07/14/2015 05:48 PM, Fam Zheng wrote: > On Tue, 07/14 17:33, Jason Wang wrote: >> >> On 07/14/2015 03:53 PM, Fam Zheng wrote: >>> The BH will be scheduled when etsec->rx_buffer_len is becoming 0, which >>> is the condition of queuing. >>> >>> Signed-off-by: Fam Zheng >> I suggest to squash th

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-14 Thread Fam Zheng
On Tue, 07/14 17:33, Jason Wang wrote: > > > On 07/14/2015 03:53 PM, Fam Zheng wrote: > > The BH will be scheduled when etsec->rx_buffer_len is becoming 0, which > > is the condition of queuing. > > > > Signed-off-by: Fam Zheng > > I suggest to squash this into patch 05/12 to unbreak bisection.

Re: [Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-14 Thread Jason Wang
On 07/14/2015 03:53 PM, Fam Zheng wrote: > The BH will be scheduled when etsec->rx_buffer_len is becoming 0, which > is the condition of queuing. > > Signed-off-by: Fam Zheng I suggest to squash this into patch 05/12 to unbreak bisection. And can we do this without a bh? Otherwise, we may need

[Qemu-devel] [PATCH for-2.4 06/12] etsec: Flush queue when rx buffer is consumed

2015-07-14 Thread Fam Zheng
The BH will be scheduled when etsec->rx_buffer_len is becoming 0, which is the condition of queuing. Signed-off-by: Fam Zheng --- hw/net/fsl_etsec/etsec.c | 9 + hw/net/fsl_etsec/etsec.h | 2 ++ hw/net/fsl_etsec/rings.c | 1 + 3 files changed, 12 insertions(+) diff --git a/hw/net/fsl_et