Re: [Qemu-devel] [PATCH for-2.5] qga: Better mapping of SEEK_* in guest-file-seek

2015-11-25 Thread Eric Blake
On 11/25/2015 01:11 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/24/2015 11:57 AM, Eric Blake wrote: >>> Exposing OS-specific SEEK_ constants in our qapi was a mistake >>> (if the host has SEEK_CUR as 1, but the guest has it as 2, then >>> the semantics are unclear what should hap

Re: [Qemu-devel] [PATCH for-2.5] qga: Better mapping of SEEK_* in guest-file-seek

2015-11-25 Thread Markus Armbruster
Eric Blake writes: > On 11/24/2015 11:57 AM, Eric Blake wrote: >> Exposing OS-specific SEEK_ constants in our qapi was a mistake >> (if the host has SEEK_CUR as 1, but the guest has it as 2, then >> the semantics are unclear what should happen); if we had a time >> machine, we would instead expos

Re: [Qemu-devel] [PATCH for-2.5] qga: Better mapping of SEEK_* in guest-file-seek

2015-11-24 Thread Marc-André Lureau
Hi On Tue, Nov 24, 2015 at 8:09 PM, Eric Blake wrote: > On 11/24/2015 11:57 AM, Eric Blake wrote: >> Exposing OS-specific SEEK_ constants in our qapi was a mistake >> (if the host has SEEK_CUR as 1, but the guest has it as 2, then >> the semantics are unclear what should happen); if we had a time

Re: [Qemu-devel] [PATCH for-2.5] qga: Better mapping of SEEK_* in guest-file-seek

2015-11-24 Thread Eric Blake
On 11/24/2015 11:57 AM, Eric Blake wrote: > Exposing OS-specific SEEK_ constants in our qapi was a mistake > (if the host has SEEK_CUR as 1, but the guest has it as 2, then > the semantics are unclear what should happen); if we had a time > machine, we would instead expose only a symbolic enum. It

[Qemu-devel] [PATCH for-2.5] qga: Better mapping of SEEK_* in guest-file-seek

2015-11-24 Thread Eric Blake
Exposing OS-specific SEEK_ constants in our qapi was a mistake (if the host has SEEK_CUR as 1, but the guest has it as 2, then the semantics are unclear what should happen); if we had a time machine, we would instead expose only a symbolic enum. It's too late to change the fact that we have an int