Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately

2015-07-29 Thread Aurelien Jarno
On 2015-07-29 17:10, Alex Bennée wrote: > > Aurelien Jarno writes: > > > Use two bools to track constants and copies instead of an enum. > > More of an explanation would be useful as to why, otherwise it seems to > me we are just increasing the size of the structure (assuming the > compiler use

Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately

2015-07-29 Thread Alex Bennée
Aurelien Jarno writes: > Use two bools to track constants and copies instead of an enum. More of an explanation would be useful as to why, otherwise it seems to me we are just increasing the size of the structure (assuming the compiler uses the same base sizes for the bool and enum). > > Cc:

Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately

2015-07-27 Thread Aurelien Jarno
On 2015-07-27 10:25, Paolo Bonzini wrote: > > > On 24/07/2015 18:30, Aurelien Jarno wrote: > > Use two bools to track constants and copies instead of an enum. > > > > Cc: Richard Henderson > > Signed-off-by: Aurelien Jarno > > --- > > tcg/optimize.c | 30 +++--- > > 1

Re: [Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately

2015-07-27 Thread Paolo Bonzini
On 24/07/2015 18:30, Aurelien Jarno wrote: > Use two bools to track constants and copies instead of an enum. > > Cc: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > tcg/optimize.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --gi

[Qemu-devel] [PATCH for-2.5 03/10] tcg/optimize: track const/copy status separately

2015-07-24 Thread Aurelien Jarno
Use two bools to track constants and copies instead of an enum. Cc: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index d2b63a4..f16eb1e 1006