Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-14 Thread Markus Armbruster
Peter Maydell writes: > On 11 December 2015 at 15:43, Max Reitz wrote: >> On 2015-12-11 at 16:40, Peter Maydell wrote: >>> >>> On 11 December 2015 at 15:30, Eric Blake wrote: On 12/11/2015 08:23 AM, Max Reitz wrote:

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Eric Blake
On 12/11/2015 08:23 AM, Max Reitz wrote: > While in the long term we want throttling to be its own block filter > BDS, in the short term we want it to be part of the BB instead of a BDS; > even in the long term we may want legacy throttling to be automatically > tied to the BB. > >

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 15:43, Max Reitz wrote: > On 2015-12-11 at 16:40, Peter Maydell wrote: >> >> On 11 December 2015 at 15:30, Eric Blake wrote: >>> >>> On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium

[Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Max Reitz
While in the long term we want throttling to be its own block filter BDS, in the short term we want it to be part of the BB instead of a BDS; even in the long term we may want legacy throttling to be automatically tied to the BB. blockdev-insert-medium and blockdev-remove-medium do not retain

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Max Reitz
On 2015-12-11 at 16:40, Peter Maydell wrote: On 11 December 2015 at 15:30, Eric Blake wrote: On 12/11/2015 08:23 AM, Max Reitz wrote: SQMP -blockdev-remove-medium +x-blockdev-remove-medium -- Formatting nit, but not worth holding this up (as it is

Re: [Qemu-devel] [PATCH for-2.5 1/1] blockdev: Mark {insert, remove}-medium experimental

2015-12-11 Thread Peter Maydell
On 11 December 2015 at 15:30, Eric Blake wrote: > On 12/11/2015 08:23 AM, Max Reitz wrote: >> >> SQMP >> -blockdev-remove-medium >> +x-blockdev-remove-medium >> -- > > Formatting nit, but not worth holding this up (as it is really our last > chance to get