Re: [Qemu-devel] [PATCH for-2.6] ppc: Fix migration of the XER register

2016-04-17 Thread David Gibson
On Fri, Apr 15, 2016 at 11:03:00AM +0200, Thomas Huth wrote: > env->xer only holds the lower bits of the XER register nowadays, the > SO, OV and CA bits are stored in separate variables (see the function > cpu_write_xer() for details). Since the migration code currently only > reads the "xer"

Re: [Qemu-devel] [PATCH for-2.6] ppc: Fix migration of the XER register

2016-04-15 Thread Thomas Huth
On 15.04.2016 12:17, Mark Cave-Ayland wrote: > On 15/04/16 10:03, Thomas Huth wrote: > >> env->xer only holds the lower bits of the XER register nowadays, the >> SO, OV and CA bits are stored in separate variables (see the function >> cpu_write_xer() for details). Since the migration code

Re: [Qemu-devel] [PATCH for-2.6] ppc: Fix migration of the XER register

2016-04-15 Thread Mark Cave-Ayland
On 15/04/16 10:03, Thomas Huth wrote: > env->xer only holds the lower bits of the XER register nowadays, the > SO, OV and CA bits are stored in separate variables (see the function > cpu_write_xer() for details). Since the migration code currently only > reads the "xer" variable, the upper bits

[Qemu-devel] [PATCH for-2.6] ppc: Fix migration of the XER register

2016-04-15 Thread Thomas Huth
env->xer only holds the lower bits of the XER register nowadays, the SO, OV and CA bits are stored in separate variables (see the function cpu_write_xer() for details). Since the migration code currently only reads the "xer" variable, the upper bits are lost during migration. Fix it by using