Re: [Qemu-devel] [PATCH for-2.7] linux-user: Fix llseek with high bit of offset_low set

On 16 August 2016 at 14:44, Riku Voipio wrote: > Hi, > > applied to linux-user-for upstream. Applied to master, thanks. -- PMM

Re: [Qemu-devel] [PATCH for-2.7] linux-user: Fix llseek with high bit of offset_low set

Hi, applied to linux-user-for upstream. Riku On Mon, Aug 15, 2016 at 10:41:35PM +0900, Chanho Park wrote: > It works perfectly. > Thanks. > > Tested-by: Chanho Park > > On Fri, Aug 12, 2016 at 2:59 AM, Peter Maydell > wrote: > > The llseek

Re: [Qemu-devel] [PATCH for-2.7] linux-user: Fix llseek with high bit of offset_low set

It works perfectly. Thanks. Tested-by: Chanho Park On Fri, Aug 12, 2016 at 2:59 AM, Peter Maydell wrote: > The llseek syscall takes two 32-bit arguments, offset_high > and offset_low, which must be combined to form a single > 64-bit offset.

[Qemu-devel] [PATCH for-2.7] linux-user: Fix llseek with high bit of offset_low set

The llseek syscall takes two 32-bit arguments, offset_high and offset_low, which must be combined to form a single 64-bit offset. Unfortunately we were combining them with (uint64_t)arg2 << 32) | arg3 and arg3 is a signed type; this meant that when promoting arg3 to a 64-bit type it would be