Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-08-02 Thread Paolo Bonzini
> >> diff --git a/hw/ide/core.c b/hw/ide/core.c > >> index 081c9eb..d117b7c 100644 > >> --- a/hw/ide/core.c > >> +++ b/hw/ide/core.c > >> @@ -823,6 +823,7 @@ static void ide_dma_cb(void *opaque, int ret) > >> } > >> if (ret < 0) { > >> if (ide_handle_rw_error(s, -ret, > >>

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-08-02 Thread Paolo Bonzini
> > The patch is (was, since it's committed :)) okay, but I think there is > > another bug in the REPORT case, where ide_rw_error and > > ide_atapi_io_error are not calling ide_set_inactive and thus are leaving > > s->bus->dma->aiocb non-NULL. > > > > Paolo > > > > Actually, won't we hit ide_dma_

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-08-01 Thread John Snow
On 08/01/2016 04:52 AM, Paolo Bonzini wrote: On 27/07/2016 00:07, John Snow wrote: If one attempts to perform a system_reset after a failed IO request that causes the VM to enter a paused state, QEMU will segfault trying to free up the pending IO requests. These requests have already been c

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-08-01 Thread John Snow
On 08/01/2016 04:52 AM, Paolo Bonzini wrote: On 27/07/2016 00:07, John Snow wrote: If one attempts to perform a system_reset after a failed IO request that causes the VM to enter a paused state, QEMU will segfault trying to free up the pending IO requests. These requests have already been c

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-08-01 Thread Paolo Bonzini
On 27/07/2016 00:07, John Snow wrote: > If one attempts to perform a system_reset after a failed IO request > that causes the VM to enter a paused state, QEMU will segfault trying > to free up the pending IO requests. > > These requests have already been completed and freed, though, so all > we

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-07-27 Thread John Snow
On 07/27/2016 09:04 AM, Laszlo Ersek wrote: > On 07/27/16 00:07, John Snow wrote: >> If one attempts to perform a system_reset after a failed IO request >> that causes the VM to enter a paused state, QEMU will segfault trying >> to free up the pending IO requests. >> >> These requests have alread

Re: [Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-07-27 Thread Laszlo Ersek
On 07/27/16 00:07, John Snow wrote: > If one attempts to perform a system_reset after a failed IO request > that causes the VM to enter a paused state, QEMU will segfault trying > to free up the pending IO requests. > > These requests have already been completed and freed, though, so all > we need

[Qemu-devel] [PATCH for-2.7 1/1] ide: fix halted IO segfault at reset

2016-07-26 Thread John Snow
If one attempts to perform a system_reset after a failed IO request that causes the VM to enter a paused state, QEMU will segfault trying to free up the pending IO requests. These requests have already been completed and freed, though, so all we need to do is free them before we enter the paused s