Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Wed, 04/27 13:18, Jason Dillaman wrote: > On Tue, Apr 26, 2016 at 7:20 PM, Fam Zheng wrote: > > On Tue, 04/26 10:42, Jason Dillaman wrote: > >> On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > >> > On Fri, 04/22 21:57, Jason Dillaman wrote: > >> >> Since this cannot automatically recover fr

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Tue, Apr 26, 2016 at 7:20 PM, Fam Zheng wrote: > On Tue, 04/26 10:42, Jason Dillaman wrote: >> On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: >> > On Fri, 04/22 21:57, Jason Dillaman wrote: >> >> Since this cannot automatically recover from a crashed QEMU client with an >> >> RBD image, per

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Tue, 04/26 10:42, Jason Dillaman wrote: > On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > > On Fri, 04/22 21:57, Jason Dillaman wrote: > >> Since this cannot automatically recover from a crashed QEMU client with an > >> RBD image, perhaps this RBD locking should not default to enabled. > >>

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > On Fri, 04/22 21:57, Jason Dillaman wrote: >> Since this cannot automatically recover from a crashed QEMU client with an >> RBD image, perhaps this RBD locking should not default to enabled. >> Additionally, this will conflict with the "exclusive

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

On Fri, 04/22 21:57, Jason Dillaman wrote: > Since this cannot automatically recover from a crashed QEMU client with an > RBD image, perhaps this RBD locking should not default to enabled. > Additionally, this will conflict with the "exclusive-lock" feature > available since the Ceph Hammer-release

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

Since this cannot automatically recover from a crashed QEMU client with an RBD image, perhaps this RBD locking should not default to enabled. Additionally, this will conflict with the "exclusive-lock" feature available since the Ceph Hammer-release since both utilize the same locking construct. As

[Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

librbd has the locking API that can be used to implement .bdrv_lockf. Signed-off-by: Fam Zheng --- block/rbd.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 5bc5b32..a495083 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -810,6 +810