Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On 12/06/2016 10:11 AM, Greg Kurz wrote: >> Given the current doc: >> > """ >> > -global driver.prop=value >> > -global driver=driver,property=property,value=value >> > Set default value of driver's property prop to value, e.g.: >> > >> > qemu-system-i386 -global

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On 12/06/2016 10:30 AM, Greg Kurz wrote: > On Mon, 5 Dec 2016 15:41:30 -0200 > Eduardo Habkost wrote: > >> > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: >>> > > On Mon, 5 Dec 2016 14:48:29 -0200 >>> > > Eduardo Habkost wrote: >>> >

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Tue, 6 Dec 2016 09:47:08 + Stefan Hajnoczi wrote: > On Mon, Dec 05, 2016 at 04:21:22PM +0100, Greg Kurz wrote: > > The current code recursively applies global properties from child up to > > parent. So, if you have: > > > > -global virtio-pci.disable-modern=on > >

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, Dec 05, 2016 at 04:21:22PM +0100, Greg Kurz wrote: > The current code recursively applies global properties from child up to > parent. So, if you have: > > -global virtio-pci.disable-modern=on > -global virtio-blk-pci.disable-modern=off > > Then the default value of disable-modern for a

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 15:41:30 -0200 Eduardo Habkost wrote: > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: > > On Mon, 5 Dec 2016 14:48:29 -0200 > > Eduardo Habkost wrote: > > > > > On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 19:14:40 +0100 Halil Pasic wrote: > On 12/05/2016 06:41 PM, Eduardo Habkost wrote: > > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: > >> > On Mon, 5 Dec 2016 14:48:29 -0200 > >> > Eduardo Habkost wrote: > >> >

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 17:01:28 +0100 Cornelia Huck wrote: > On Mon, 5 Dec 2016 16:42:00 +0100 > Cornelia Huck wrote: > > > On Mon, 05 Dec 2016 16:21:22 +0100 > > Greg Kurz wrote: > > > > AFAIK, libvirt's XML doesn't know

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 14:48:29 -0200 Eduardo Habkost wrote: > On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > > On Mon, 05 Dec 2016 16:21:22 +0100 > > Greg Kurz wrote: > > > > > The current code recursively applies global properties from

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 16:42:00 +0100 Cornelia Huck wrote: > On Mon, 05 Dec 2016 16:21:22 +0100 > Greg Kurz wrote: > > > The current code recursively applies global properties from child up to > > parent. So, if you have: > > > > -global

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On 12/05/2016 06:41 PM, Eduardo Habkost wrote: > On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: >> > On Mon, 5 Dec 2016 14:48:29 -0200 >> > Eduardo Habkost wrote: >> > >>> > > On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > > > On Mon,

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 14:48:29 -0200 Eduardo Habkost wrote: > On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > > On Mon, 05 Dec 2016 16:21:22 +0100 > > Greg Kurz wrote: > > > > > The current code recursively applies global properties from child

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, Dec 05, 2016 at 06:25:55PM +0100, Cornelia Huck wrote: > On Mon, 5 Dec 2016 14:48:29 -0200 > Eduardo Habkost wrote: > > > On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > > > On Mon, 05 Dec 2016 16:21:22 +0100 > > > Greg Kurz wrote: >

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, Dec 05, 2016 at 04:21:22PM +0100, Greg Kurz wrote: > The current code recursively applies global properties from child up to > parent. So, if you have: > > -global virtio-pci.disable-modern=on > -global virtio-blk-pci.disable-modern=off > > Then the default value of disable-modern for a

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, Dec 05, 2016 at 04:42:00PM +0100, Cornelia Huck wrote: > On Mon, 05 Dec 2016 16:21:22 +0100 > Greg Kurz wrote: > > > The current code recursively applies global properties from child up to > > parent. So, if you have: > > > > -global virtio-pci.disable-modern=on > >

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 5 Dec 2016 16:42:00 +0100 Cornelia Huck wrote: > On Mon, 05 Dec 2016 16:21:22 +0100 > Greg Kurz wrote: > > AFAIK, libvirt's XML doesn't know about modern/legacy modes for virtio > > devices. Early adopters of virtio 1.0 had to rely on the > >

Re: [Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

On Mon, 05 Dec 2016 16:21:22 +0100 Greg Kurz wrote: > The current code recursively applies global properties from child up to > parent. So, if you have: > > -global virtio-pci.disable-modern=on > -global virtio-blk-pci.disable-modern=off > > Then the default value of

[Qemu-devel] [PATCH for-2.8] qdev: apply global properties in reverse order

The current code recursively applies global properties from child up to parent. So, if you have: -global virtio-pci.disable-modern=on -global virtio-blk-pci.disable-modern=off Then the default value of disable-modern for a virtio-blk-pci device is on, which looks wrong from an OOP perspective.