Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-14 Thread Lluís Vilanova
Daniel P Berrange writes: > On Tue, Sep 13, 2016 at 08:36:25PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> >> Daniel P Berrange writes: >> >> >> >> > I previously split the global trace-events file up into

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-14 Thread Lluís Vilanova
Daniel P Berrange writes: > On Fri, Sep 09, 2016 at 03:16:50PM +0200, Lluís Vilanova wrote: >> > The various _DSTATE variables are still arbitrarily scattered in >> > memory, as opposed to in a contiguous cache friendly array, which >> > is one of the goals of Paolo's original change. >> >> >

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-14 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 08:36:25PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > >> Daniel P Berrange writes: > >> > >> > I previously split the global trace-events file up into one file > >> > per-subdirectory to

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > I previously split the global trace-events file up into one file >> > per-subdirectory to avoid merge conflict hell. >> [...] >> >> Sorry, I could not find the

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Daniel P. Berrange
On Fri, Sep 09, 2016 at 03:16:50PM +0200, Lluís Vilanova wrote: > > The various _DSTATE variables are still arbitrarily scattered in > > memory, as opposed to in a contiguous cache friendly array, which > > is one of the goals of Paolo's original change. > > > That said, I'm unclear on how much

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > I previously split the global trace-events file up into one file > > per-subdirectory to avoid merge conflict hell. > [...] > > Sorry, I could not find the message where the infrastructure is

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 06:05:07PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Tue, Sep 13, 2016 at 03:54:01PM +0100, Stefan Hajnoczi wrote: > >> Dan: Ping? > >> > >> A few people have reviewed this series. A v2 would be appreciated. I'd > >> like to merge it quickly and

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Lluís Vilanova
Daniel P Berrange writes: > On Tue, Sep 13, 2016 at 03:54:01PM +0100, Stefan Hajnoczi wrote: >> Dan: Ping? >> >> A few people have reviewed this series. A v2 would be appreciated. I'd >> like to merge it quickly and as early into the development cycle as >> possible. > Sorry, been focused on

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Daniel P. Berrange
On Tue, Sep 13, 2016 at 03:54:01PM +0100, Stefan Hajnoczi wrote: > Dan: Ping? > > A few people have reviewed this series. A v2 would be appreciated. I'd > like to merge it quickly and as early into the development cycle as > possible. Sorry, been focused on other series, but will try and post

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-13 Thread Stefan Hajnoczi
Dan: Ping? A few people have reviewed this series. A v2 would be appreciated. I'd like to merge it quickly and as early into the development cycle as possible. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-09 Thread Lluís Vilanova
Daniel P Berrange writes: > On Fri, Sep 09, 2016 at 01:03:51PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> >> Daniel P Berrange writes: >> >> >> >> > I previously split the global trace-events file up into

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-09 Thread Daniel P. Berrange
On Fri, Sep 09, 2016 at 01:03:51PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > >> Daniel P Berrange writes: > >> > >> > I previously split the global trace-events file up into one file > >> > per-subdirectory to

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-09 Thread Lluís Vilanova
Daniel P Berrange writes: > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> >> > I previously split the global trace-events file up into one file >> > per-subdirectory to avoid merge conflict hell. >> [...] >> >> Sorry, I could not find the

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-08 Thread Lluís Vilanova
Daniel P Berrange writes: > I previously split the global trace-events file up into one file > per-subdirectory to avoid merge conflict hell. [...] Sorry, I could not find the message where the infrastructure is modified to provide this. But I think there's a more efficient way to provide

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-09-08 Thread Daniel P. Berrange
On Thu, Sep 08, 2016 at 03:23:26PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > I previously split the global trace-events file up into one file > > per-subdirectory to avoid merge conflict hell. > [...] > > Sorry, I could not find the message where the infrastructure is

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Paolo Bonzini
On 10/08/2016 10:39, Fam Zheng wrote: > Then the script needs to be updated to work with different package management > systems (rpm and deb). For now they only call standard Linux commands. That's > least of the problem, though. > > The more tricky question is how the script can tell which

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 04:05:06PM +0200, Lluís Vilanova wrote: > Daniel P Berrange writes: > > > I previously split the global trace-events file up into one file > > per-subdirectory to avoid merge conflict hell. > > > This series builds on that to now actually generate the individual > > trace

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Lluís Vilanova
Daniel P Berrange writes: > I previously split the global trace-events file up into one file > per-subdirectory to avoid merge conflict hell. > This series builds on that to now actually generate the individual > trace files per-subdirectory too. The key benefit of doing this is > that a change

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 04:39:21PM +0800, Fam Zheng wrote: > On Wed, 08/10 09:24, Daniel P. Berrange wrote: > > On Wed, Aug 10, 2016 at 04:13:10PM +0800, Fam Zheng wrote: > > > On Wed, 08/10 09:06, Daniel P. Berrange wrote: > > > > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote: > > > >

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Fam Zheng
On Wed, 08/10 09:24, Daniel P. Berrange wrote: > On Wed, Aug 10, 2016 at 04:13:10PM +0800, Fam Zheng wrote: > > On Wed, 08/10 09:06, Daniel P. Berrange wrote: > > > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote: > > > > On Tue, 08/09 18:11, Daniel P. Berrange wrote: > > > > > > > > >

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 04:13:10PM +0800, Fam Zheng wrote: > On Wed, 08/10 09:06, Daniel P. Berrange wrote: > > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote: > > > On Tue, 08/09 18:11, Daniel P. Berrange wrote: > > > > > > > > Can we get this report to include details of the > > > >

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Fam Zheng
On Wed, 08/10 09:06, Daniel P. Berrange wrote: > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote: > > On Tue, 08/09 18:11, Daniel P. Berrange wrote: > > > > > > Can we get this report to include details of the > > > > > > a) the software versions of gcc, binutils, and any -devel

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-10 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote: > On Tue, 08/09 18:11, Daniel P. Berrange wrote: > > > > Can we get this report to include details of the > > > > a) the software versions of gcc, binutils, and any -devel packages > > we're building against > > > > b) the

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread Fam Zheng
On Tue, 08/09 18:11, Daniel P. Berrange wrote: > so we don't have to go digging into the docker test systemm to > try and reverse engineer this info Actually, digging this info is pretty easy if you already use docker test locally (if you don't, may I ask why?). Just append DEBUG=1 and you can

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread Fam Zheng
On Tue, 08/09 18:11, Daniel P. Berrange wrote: > > Can we get this report to include details of the > > a) the software versions of gcc, binutils, and any -devel packages > we're building against > > b) the exact arguments + env variables used to invoke configure, > not merely its

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread Daniel P. Berrange
ally. > > Message-id: 1470756748-18933-1-git-send-email-berra...@redhat.com > Type: series > Subject: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event > files > > === TEST SCRIPT BEGIN === > #!/bin/bash > set -e > git submodule update --init dtc >

Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1470756748-18933-1-git-send-email-berra...@redhat.com Type: series Subject: [Qemu-devel] [PATCH for-2.8 v1 00/60

[Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files

2016-08-09 Thread Daniel P. Berrange
I previously split the global trace-events file up into one file per-subdirectory to avoid merge conflict hell. This series builds on that to now actually generate the individual trace files per-subdirectory too. The key benefit of doing this is that a change in a trace-events file will no longer