Re: [Qemu-devel] [PATCH for-2.8 v1 09/60] trace: remove use of TRACE_VCPU_EVENT_COUNT in cpu.h

2016-09-02 Thread Stefan Hajnoczi
On Tue, Aug 09, 2016 at 04:31:37PM +0100, Daniel P. Berrange wrote: > +/* Keep this a multiple of 8, or better yet a multiple > + * of the platform word size, since the struct > + * will be padded out to that regardless. > + */ > +#define TRACE_MAX_VCPU_EVENT 32 Hard-coding this is awkward. Can i

[Qemu-devel] [PATCH for-2.8 v1 09/60] trace: remove use of TRACE_VCPU_EVENT_COUNT in cpu.h

2016-08-09 Thread Daniel P. Berrange
The CPUState struct has a bitmap tracking which VCPU events are currently active. This is indexed based on the event ID values, and sized according the maximum TraceEventVCPUID enum value. Since there will the possibility of having multiple event groups, the indexes will potentially overlap. Rathe