On Wed, Mar 15, 2017 at 10:59:24AM +, Daniel P. Berrange wrote:
> On Wed, Mar 15, 2017 at 10:26:44AM +, Daniel P. Berrange wrote:
> > On Wed, Mar 15, 2017 at 06:18:35PM +0800, Stefan Hajnoczi wrote:
> > > On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> > > > And here's where I
On Wed, Mar 15, 2017 at 10:26:44AM +, Daniel P. Berrange wrote:
> On Wed, Mar 15, 2017 at 06:18:35PM +0800, Stefan Hajnoczi wrote:
> > On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> > > And here's where I'm stuck: the makefiles are broken. Touching
> > > scripts/tracetool/format
On Wed, Mar 15, 2017 at 06:18:35PM +0800, Stefan Hajnoczi wrote:
> On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> > And here's where I'm stuck: the makefiles are broken. Touching
> > scripts/tracetool/format/h.py does NOT cause tracetool to be re-run by a
> > mere 'make'; I've had t
On Fri, Mar 10, 2017 at 02:49:22PM -0600, Eric Blake wrote:
> On 03/09/2017 09:25 PM, Eric Blake wrote:
> > [adding Stefan in cc, as trace maintainer]
> >
> > On 03/09/2017 09:15 PM, Eric Blake wrote:
> >
> > Perhaps I should update the subject to mention trace?
> >
> >> trace-events lists the p
On 03/09/2017 09:25 PM, Eric Blake wrote:
> [adding Stefan in cc, as trace maintainer]
>
> On 03/09/2017 09:15 PM, Eric Blake wrote:
>
> Perhaps I should update the subject to mention trace?
>
>> trace-events lists the parameters for mirror_yield consistently
>> with other events (cnt just after
[adding Stefan in cc, as trace maintainer]
On 03/09/2017 09:15 PM, Eric Blake wrote:
Perhaps I should update the subject to mention trace?
> trace-events lists the parameters for mirror_yield consistently
> with other events (cnt just after s, like in mirror_before_sleep;
> in_flight last, like
trace-events lists the parameters for mirror_yield consistently
with other events (cnt just after s, like in mirror_before_sleep;
in_flight last, like in mirror_yield_in_flight). But the callers
were passing parameters in the wrong order, leading to poor trace
messages, including type truncation w