Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py

2017-03-14 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Mar 13, 2017 at 10:36 AM Markus Armbruster > wrote: > >> This reverts commit 3313b61's changes to tests/qapi-schema/, except >> for tests/qapi-schema/doc-*. >> >> > Do we expect those files to change? If not, or not much, I think i't s > rather better t

Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py

2017-03-14 Thread Marc-André Lureau
Hi On Mon, Mar 13, 2017 at 10:36 AM Markus Armbruster wrote: > This reverts commit 3313b61's changes to tests/qapi-schema/, except > for tests/qapi-schema/doc-*. > > Do we expect those files to change? If not, or not much, I think i't s rather better to keep the docs to exercise the parser in va

Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py

2017-03-14 Thread Markus Armbruster
Eric Blake writes: > On 03/13/2017 01:18 AM, Markus Armbruster wrote: >> This reverts commit 3313b61's changes to tests/qapi-schema/, except >> for tests/qapi-schema/doc-*. >> >> Signed-off-by: Markus Armbruster >> --- > > Tested by doing: > > $ git checkout 3313b61 > $ git cherry-pick 07c7b92

Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py

2017-03-13 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > This reverts commit 3313b61's changes to tests/qapi-schema/, except > for tests/qapi-schema/doc-*. > > Signed-off-by: Markus Armbruster > --- Tested by doing: $ git checkout 3313b61 $ git cherry-pick 07c7b92 # the current id on your qapi-doc br

[Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py

2017-03-12 Thread Markus Armbruster
This reverts commit 3313b61's changes to tests/qapi-schema/, except for tests/qapi-schema/doc-*. Signed-off-by: Markus Armbruster --- tests/qapi-schema/alternate-any.err| 2 +- tests/qapi-schema/alternate-any.json | 4 - tests/qapi-schema/alternate-array.err