Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-06 Thread Longpeng (Mike)
Hi Eric, On 2016/12/6 3:15, Eric Blake wrote: > On 12/05/2016 02:59 AM, Longpeng(Mike) wrote: >> This patch add standart DES support. > > s/standart/standard/ > >> >> Signed-off-by: Longpeng(Mike) >> --- > >> +++ b/qapi/crypto.json >> @@ -75,7 +75,7 @@ >> { 'enum':

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-06 Thread Gonglei (Arei)
> > > > > > > } > > > > > > diff --git a/qapi/crypto.json b/qapi/crypto.json > > > > > > index 5c9d7d4..d403ab9 100644 > > > > > > --- a/qapi/crypto.json > > > > > > +++ b/qapi/crypto.json > > > > > > @@ -75,7 +75,7 @@ > > > > > > { 'enum': 'QCryptoCipherAlgorithm', > > > > > >

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-06 Thread Daniel P. Berrange
On Tue, Dec 06, 2016 at 01:23:31AM +, Gonglei (Arei) wrote: > > > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Tuesday, December 06, 2016 12:59 AM > > To: Gonglei (Arei) > > Cc: longpeng; ebl...@redhat.com; arm...@redhat.com; > > qemu-devel@nongnu.org; Wubin (H); Zhoujian

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Gonglei (Arei)
> > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, December 06, 2016 12:59 AM > To: Gonglei (Arei) > Cc: longpeng; ebl...@redhat.com; arm...@redhat.com; > qemu-devel@nongnu.org; Wubin (H); Zhoujian (jay, Euler) > Subject: Re: [PATCH for-2.9 1/3] crypto: add standard des

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Eric Blake
On 12/05/2016 02:59 AM, Longpeng(Mike) wrote: > This patch add standart DES support. s/standart/standard/ > > Signed-off-by: Longpeng(Mike) > --- > +++ b/qapi/crypto.json > @@ -75,7 +75,7 @@ > { 'enum': 'QCryptoCipherAlgorithm', >'prefix': 'QCRYPTO_CIPHER_ALG', >

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 09:29:59AM +, Gonglei (Arei) wrote: > > > > > switch (alg) { > > > +case QCRYPTO_CIPHER_ALG_DES: > > > case QCRYPTO_CIPHER_ALG_DES_RFB: > > > case QCRYPTO_CIPHER_ALG_AES_128: > > > case QCRYPTO_CIPHER_ALG_AES_192: > > > @@ -256,11 +257,17 @@

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 07:11:37PM +0800, Longpeng (Mike) wrote: > Hi Daniel, > > On 2016/12/5 17:18, Daniel P. Berrange wrote: > > > On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: > .. > >> diff --git a/qapi/crypto.json b/qapi/crypto.json > >> index 5c9d7d4..d403ab9 100644

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Longpeng (Mike)
Hi Daniel, On 2016/12/5 17:18, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: .. >> diff --git a/qapi/crypto.json b/qapi/crypto.json >> index 5c9d7d4..d403ab9 100644 >> --- a/qapi/crypto.json >> +++ b/qapi/crypto.json >> @@ -75,7 +75,7 @@ >> {

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Gonglei (Arei)
> > > switch (alg) { > > +case QCRYPTO_CIPHER_ALG_DES: > > case QCRYPTO_CIPHER_ALG_DES_RFB: > > case QCRYPTO_CIPHER_ALG_AES_128: > > case QCRYPTO_CIPHER_ALG_AES_192: > > @@ -256,11 +257,17 @@ QCryptoCipher > *qcrypto_cipher_new(QCryptoCipherAlgorithm alg, > > ctx =

Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Daniel P. Berrange
On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: > This patch add standart DES support. > > Signed-off-by: Longpeng(Mike) > --- > crypto/cipher-gcrypt.c | 3 +++ > crypto/cipher-nettle.c | 13 ++--- > crypto/cipher.c| 5 - >

[Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support

2016-12-05 Thread Longpeng(Mike)
This patch add standart DES support. Signed-off-by: Longpeng(Mike) --- crypto/cipher-gcrypt.c | 3 +++ crypto/cipher-nettle.c | 13 ++--- crypto/cipher.c| 5 - qapi/crypto.json | 2 +- 4 files changed, 18 insertions(+), 5 deletions(-) diff