Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread Zhang Chen
On 12/22/2016 08:52 PM, Eric Blake wrote: [resend, I don't know how I botched the From: line in my first attempt, or if that botch changed who received the mail] On 12/22/2016 12:08 AM, Zhang Chen wrote: Make sense, this command trying to collect status on whether an error has occurred, and t

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread Eric Blake
[resend, I don't know how I botched the From: line in my first attempt, or if that botch changed who received the mail] On 12/22/2016 12:08 AM, Zhang Chen wrote: >>> Make sense, this command trying to collect status on whether >>> an error has occurred, and the "replication_get_error_all(errp)" >>

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-22 Thread addr_cc
On 12/22/2016 12:08 AM, Zhang Chen wrote: >>> Make sense, this command trying to collect status on whether >>> an error has occurred, and the "replication_get_error_all(errp)" >>> is always succeeds. So, Can you suggest to me the right name? >> If replication_get_error_all() always succeeds, then w

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-21 Thread Zhang Chen
On 12/21/2016 10:25 PM, Eric Blake wrote: On 12/21/2016 12:56 AM, Zhang Chen wrote: +void qmp_xen_get_replication_error(Error **errp) +{ +replication_get_error_all(errp); +} Is this trying to cause a replication error, or is it trying to collect status on whether an error

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-21 Thread Eric Blake
On 12/21/2016 12:56 AM, Zhang Chen wrote: >>> +void qmp_xen_get_replication_error(Error **errp) >>> +{ >>> +replication_get_error_all(errp); >>> +} >> Is this trying to cause a replication error, or is it trying to collect >> status on whether an error has occurred? The name 'get

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Zhang Chen
On 12/21/2016 08:18 AM, Stefano Stabellini wrote: On Fri, 16 Dec 2016, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24 ++

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Zhang Chen
On 12/20/2016 10:42 PM, Eric Blake wrote: On 12/15/2016 08:46 PM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24 +++

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Stefano Stabellini
On Fri, 16 Dec 2016, Zhang Chen wrote: > We can call this qmp command to do checkpoint outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt | 24 > migration/colo.c | 10 +

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-20 Thread Eric Blake
On 12/15/2016 08:46 PM, Zhang Chen wrote: > We can call this qmp command to do checkpoint outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt | 24 > migration/colo.c | 10 ++

[Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

2016-12-15 Thread Zhang Chen
We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24 migration/colo.c | 10 ++ qapi-schema.json | 22 +