Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/12/2016 18:47, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 14/12/2016 14:48, Eduardo Habkost wrote: > How do you find all abstract TypeInfo in the source? The uninitiated > might grep for .abstract

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-15 Thread Paolo Bonzini
On 14/12/2016 18:47, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 14/12/2016 14:48, Eduardo Habkost wrote: How do you find all abstract TypeInfo in the source? The uninitiated might grep for .abstract = true, and be misled. The initiated will be

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-14 Thread Markus Armbruster
Paolo Bonzini writes: > On 14/12/2016 14:48, Eduardo Habkost wrote: >>> How do you find all abstract TypeInfo in the source? The uninitiated >>> might grep for .abstract = true, and be misled. The initiated will be >>> annoyed instead, because grepping for *absence* of

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-14 Thread Eduardo Habkost
On Wed, Dec 14, 2016 at 06:07:48PM +0100, Paolo Bonzini wrote: > > > On 14/12/2016 14:48, Eduardo Habkost wrote: > >> How do you find all abstract TypeInfo in the source? The uninitiated > >> might grep for .abstract = true, and be misled. The initiated will be > >> annoyed instead, because

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-14 Thread Paolo Bonzini
On 14/12/2016 14:48, Eduardo Habkost wrote: >> How do you find all abstract TypeInfo in the source? The uninitiated >> might grep for .abstract = true, and be misled. The initiated will be >> annoyed instead, because grepping for *absence* of .instance_size = is >> bothersome. >> >> I suspect

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-14 Thread Eduardo Habkost
On Wed, Dec 14, 2016 at 02:04:50PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > "qom-list-types abstract=false" currently returns all interface > > types, as if they were not abstract. Fix this by making sure all > > interface types are abstract. > > > >

Re: [Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-14 Thread Markus Armbruster
Eduardo Habkost writes: > "qom-list-types abstract=false" currently returns all interface > types, as if they were not abstract. Fix this by making sure all > interface types are abstract. > > All interface types have instance_size == 0, so we can use > it to set

[Qemu-devel] [PATCH for-2.9 v2] qom: Make all interface types abstract

2016-12-12 Thread Eduardo Habkost
"qom-list-types abstract=false" currently returns all interface types, as if they were not abstract. Fix this by making sure all interface types are abstract. All interface types have instance_size == 0, so we can use it to set abstract=true on type_initialize(). Signed-off-by: Eduardo Habkost