Re: [Qemu-devel] [PATCH for-3.0 1/9] migration: simplify check to use qemu file buffer

2018-07-05 Thread Juan Quintela
Peter Xu wrote: > Firstly, renaming the old matching_page_sizes variable to > matching_target_page_size, which suites more to what it did (it only > checks against target page size rather than multiple page sizes). > Meanwhile, simplify the check logic a bit, and enhance the comments. > Should hav

Re: [Qemu-devel] [PATCH for-3.0 1/9] migration: simplify check to use qemu file buffer

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 10:01:09AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Firstly, renaming the old matching_page_sizes variable to > > matching_target_page_size, which suites more to what it did (it only > > checks against target page size rather than mult

Re: [Qemu-devel] [PATCH for-3.0 1/9] migration: simplify check to use qemu file buffer

2018-07-05 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Firstly, renaming the old matching_page_sizes variable to > matching_target_page_size, which suites more to what it did (it only > checks against target page size rather than multiple page sizes). > Meanwhile, simplify the check logic a bit, and enhance the c

[Qemu-devel] [PATCH for-3.0 1/9] migration: simplify check to use qemu file buffer

2018-07-04 Thread Peter Xu
Firstly, renaming the old matching_page_sizes variable to matching_target_page_size, which suites more to what it did (it only checks against target page size rather than multiple page sizes). Meanwhile, simplify the check logic a bit, and enhance the comments. Should have no functional change. Si