Re: [Qemu-devel] [PATCH for-3.2 v5 13/19] qdev-props: remove errp from GlobalProperty

2018-12-10 Thread Igor Mammedov
On Tue, 4 Dec 2018 18:20:17 +0400 Marc-André Lureau wrote: > All qdev_prop_register_global() set &error_fatal for errp, except > '-rtc driftfix=slew', which arguably should also use &error_fatal, as this one shouldn't fail if machine has mc146818rtc instantiated, it should warn only in case when

[Qemu-devel] [PATCH for-3.2 v5 13/19] qdev-props: remove errp from GlobalProperty

2018-12-04 Thread Marc-André Lureau
All qdev_prop_register_global() set &error_fatal for errp, except '-rtc driftfix=slew', which arguably should also use &error_fatal, as otherwise failing to apply the property would only report a warning. Signed-off-by: Marc-André Lureau --- include/hw/qdev-core.h| 6 -- hw/core/qdev-pro