Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-05-03 Thread Peter Maydell
On Mon, 25 Mar 2019 at 10:25, Peter Maydell wrote: > > On Mon, 18 Mar 2019 at 15:59, Alex Bennée wrote: > > > > > > Peter Maydell writes: [...] > > > Support this by making kvm_arch_put_registers() synchronize > > > CPU state back into the list. We sync only those registers > > > where the

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-25 Thread gengdongjiu
On 2019/3/25 18:25, Peter Maydell wrote: > Further testing from Alex suggests this is some unrelated > bug or regression (ie not caused by this patch), but: > since the only in-tree use for this patch is to get nested > debugging working and it would be broken for this other > reason even with

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-25 Thread Peter Maydell
On Mon, 18 Mar 2019 at 15:59, Alex Bennée wrote: > > > Peter Maydell writes: > > > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > > don't support having QEMU change the values of system registers > > (aka coprocessor registers for AArch32). This is because although > >

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-19 Thread gengdongjiu
On 2019/3/18 20:49, Peter Maydell wrote: > On Mon, 18 Mar 2019 at 12:34, gengdongjiu wrote: >> >> >> >> On 2019/3/16 4:11, Philippe Mathieu-Daudé wrote: Signed-off-by: Peter Maydell --- Should we try to put this in for rc1? Not sure... Testing definitely appreciated. >>> You

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-18 Thread Alex Bennée
Peter Maydell writes: > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > don't support having QEMU change the values of system registers > (aka coprocessor registers for AArch32). This is because although > kvm_arch_get_registers() calls write_list_to_cpustate() to >

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-18 Thread gengdongjiu
On 2019/3/16 4:11, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Peter Maydell >> --- >> Should we try to put this in for rc1? Not sure... Testing >> definitely appreciated. > You might include it for rc1 and we still have rc2/rc3 to revert it. why we still have rc2/rc3 to revert it? If we

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-18 Thread Peter Maydell
On Mon, 18 Mar 2019 at 12:34, gengdongjiu wrote: > > > > On 2019/3/16 4:11, Philippe Mathieu-Daudé wrote: > >> Signed-off-by: Peter Maydell > >> --- > >> Should we try to put this in for rc1? Not sure... Testing > >> definitely appreciated. > > You might include it for rc1 and we still have

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-17 Thread Auger Eric
Hi Peter, On 3/15/19 3:30 PM, Peter Maydell wrote: > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > don't support having QEMU change the values of system registers > (aka coprocessor registers for AArch32). This is because although > kvm_arch_get_registers() calls

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-15 Thread Philippe Mathieu-Daudé
On 3/15/19 3:30 PM, Peter Maydell wrote: > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > don't support having QEMU change the values of system registers > (aka coprocessor registers for AArch32). This is because although > kvm_arch_get_registers() calls

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-15 Thread Richard Henderson
On 3/15/19 7:30 AM, Peter Maydell wrote: > This commit is the same as commit 823e1b3818f9b10b824ddc which we > had to revert in commit 942f99c825fc94c8b1a4, except that the bug > which was preventing EDK2 guest firmware running has been fixed: > kvm_arm_reset_vcpu() now calls

[Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-15 Thread Peter Maydell
At the moment the Arm implementations of kvm_arch_{get,put}_registers() don't support having QEMU change the values of system registers (aka coprocessor registers for AArch32). This is because although kvm_arch_get_registers() calls write_list_to_cpustate() to update the CPU state struct fields