Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-05 Thread Li Zhijian
On 12/05/2018 11:33 PM, Michael S. Tsirkin wrote: On Wed, Dec 05, 2018 at 06:28:11PM +0800, Li Zhijian wrote: Hi Michael I cooked a draft with cp_portable to import bootparam.h, could you have a look. diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 0a964f

Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2018 at 06:28:11PM +0800, Li Zhijian wrote: > Hi Michael > > I cooked a draft with cp_portable to import bootparam.h, could you have a > look. > > diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh > index 0a964fe..1beeceb 100755 > --- a/scripts/update

Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-05 Thread Li Zhijian
Hi Michael I cooked a draft with cp_portable to import bootparam.h, could you have a look. diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 0a964fe..1beeceb 100755 --- a/scripts/update-linux-headers.sh +++ b/scripts/update-linux-headers.sh @@ -44,6 +44,12 @@ c

Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-04 Thread Li Zhijian
On 12/04/2018 09:06 AM, Michael S. Tsirkin wrote: On Mon, Dec 03, 2018 at 10:48:51PM +0800, Li Zhijian wrote: It provides setup_data struct and header fields CC: Michael S. Tsirkin Signed-off-by: Li Zhijian Sorry I was unclear when I said "import it from Linux". Sorry, it's my fault. T

Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-03 Thread Michael S. Tsirkin
On Mon, Dec 03, 2018 at 10:48:51PM +0800, Li Zhijian wrote: > It provides setup_data struct and header fields > > CC: Michael S. Tsirkin > Signed-off-by: Li Zhijian Sorry I was unclear when I said "import it from Linux". The way to import it is to copy the header from the linux kernel by addi

Re: [Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-03 Thread Richard Henderson
On 12/3/18 8:48 AM, Li Zhijian wrote: > #include "hw/net/ne2000-isa.h" > +#include > > /* debug PC/ISA interrupts */ > //#define DEBUG_IRQ > @@ -820,20 +821,6 @@ static long get_file_size(FILE *f) > return size; > } > > -/* setup_data types */ > -#define SETUP_NONE 0 > -#define SE

[Qemu-devel] [PATCH for-4.0 v3 3/4] i386: import bootparam.h

2018-12-03 Thread Li Zhijian
It provides setup_data struct and header fields CC: Michael S. Tsirkin Signed-off-by: Li Zhijian --- V3: new patch --- hw/i386/pc.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 067d23a..8db7417 100644 --- a/hw/i386/pc.c +