Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2019-01-01 Thread David Gibson
On Wed, 19 Dec 2018 10:29:41 +0100 Markus Armbruster wrote: > David Gibson writes: > > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > > Double-checking: is it okay to report some failures of this function > (one of two H_RESOURCE failures, to be

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-25 Thread Fei Li
Hi all, As I am leaving my current company and most reviewers are on holiday, I'd like to send a new version now: v9: "qemu_thread: Make qemu_thread_create() handle errors properly", although some details like whether it is appropriate to report the error to be seen by the management layer. And

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-23 Thread Fei Li
On 12/24/2018 11:34 AM, Peter Xu wrote: On Fri, Dec 21, 2018 at 05:36:57PM +0800, Fei Li wrote: On 12/19/2018 08:14 PM, Fei Li wrote: On 12/19/2018 06:10 PM, Markus Armbruster wrote: Fei Li writes: On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-23 Thread Peter Xu
On Fri, Dec 21, 2018 at 05:36:57PM +0800, Fei Li wrote: > > On 12/19/2018 08:14 PM, Fei Li wrote: > > > > On 12/19/2018 06:10 PM, Markus Armbruster wrote: > > > Fei Li writes: > > > > > > > On 12/13/2018 03:26 PM, Markus Armbruster wrote: > > > > > There's a question for David Gibson inline. 

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-21 Thread Fei Li
On 12/19/2018 08:14 PM, Fei Li wrote: On 12/19/2018 06:10 PM, Markus Armbruster wrote: Fei Li writes: On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson inline.  Please search for /ppc/. Fei Li writes: Make qemu_thread_create() return a Boolean to

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Fei Li
On 12/20/2018 01:29 AM, Eric Blake wrote: On 12/19/18 6:14 AM, Fei Li wrote:    28 files changed, 243 insertions(+), 101 deletions(-) I recommend to split this patch.  First part adds the Error ** parameter to qemu_thread_create(), passing _abort everywhere. No functional change. 

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Eric Blake
On 12/19/18 6:14 AM, Fei Li wrote:    28 files changed, 243 insertions(+), 101 deletions(-) I recommend to split this patch.  First part adds the Error ** parameter to qemu_thread_create(), passing _abort everywhere.  No functional change.  Subsequent patches then improve on _abort.  This

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Fei Li
On 12/19/2018 06:10 PM, Markus Armbruster wrote: Fei Li writes: On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson inline. Please search for /ppc/. Fei Li writes: Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Markus Armbruster
Fei Li writes: > On 12/17/2018 03:29 PM, Fei Li wrote: >> >> >> On 12/13/2018 03:26 PM, Markus Armbruster wrote: >>> There's a question for David Gibson inline.  Please search for /ppc/. >>> >>> Fei Li writes: >>> Make qemu_thread_create() return a Boolean to indicate if it succeeds

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Markus Armbruster
Fei Li writes: > On 12/13/2018 03:26 PM, Markus Armbruster wrote: >> There's a question for David Gibson inline. Please search for /ppc/. >> >> Fei Li writes: >> >>> Make qemu_thread_create() return a Boolean to indicate if it succeeds >>> rather than failing with an error. And add an Error

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Markus Armbruster
David Gibson writes: > On Thu, 13 Dec 2018 08:26:48 +0100 > Markus Armbruster wrote: > >> There's a question for David Gibson inline. Please search for /ppc/. >> >> Fei Li writes: >> >> > Make qemu_thread_create() return a Boolean to indicate if it succeeds >> > rather than failing with an

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-18 Thread Fei Li
On 12/17/2018 03:29 PM, Fei Li wrote: On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson inline.  Please search for /ppc/. Fei Li writes: Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than failing with an error. And add

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-16 Thread Fei Li
On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson inline. Please search for /ppc/. Fei Li writes: Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than failing with an error. And add an Error parameter to hold the error

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-13 Thread David Gibson
On Thu, 13 Dec 2018 08:26:48 +0100 Markus Armbruster wrote: > There's a question for David Gibson inline. Please search for /ppc/. > > Fei Li writes: > > > Make qemu_thread_create() return a Boolean to indicate if it succeeds > > rather than failing with an error. And add an Error parameter

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-12 Thread Markus Armbruster
There's a question for David Gibson inline. Please search for /ppc/. Fei Li writes: > Make qemu_thread_create() return a Boolean to indicate if it succeeds > rather than failing with an error. And add an Error parameter to hold > the error message and let the callers handle it. The "rather

[Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-11 Thread Fei Li
Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than failing with an error. And add an Error parameter to hold the error message and let the callers handle it. Cc: Markus Armbruster Cc: Daniel P. Berrangé Cc: Dr. David Alan Gilbert Signed-off-by: Fei Li ---