Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-29 Thread Stefano Garzarella
On Fri, Mar 29, 2019 at 01:50:04PM +, Peter Maydell wrote: > On Fri, 29 Mar 2019 at 13:13, Stefano Garzarella wrote: > > > > On Thu, Mar 28, 2019 at 03:26:35PM +, Peter Maydell wrote: > > > In the stripe8() function we use a variable length array; however > > > we know that the maximum len

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-29 Thread Peter Maydell
On Fri, 29 Mar 2019 at 13:13, Stefano Garzarella wrote: > > On Thu, Mar 28, 2019 at 03:26:35PM +, Peter Maydell wrote: > > In the stripe8() function we use a variable length array; however > > we know that the maximum length required is MAX_NUM_BUSSES. Use > > a fixed-length array and an asser

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-29 Thread Stefano Garzarella
On Thu, Mar 28, 2019 at 03:26:35PM +, Peter Maydell wrote: > In the stripe8() function we use a variable length array; however > we know that the maximum length required is MAX_NUM_BUSSES. Use > a fixed-length array and an assert instead. > > Signed-off-by: Peter Maydell > --- > hw/ssi/xilin

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-28 Thread Alistair Francis
On Thu, Mar 28, 2019 at 8:39 AM Peter Maydell wrote: > > In the stripe8() function we use a variable length array; however > we know that the maximum length required is MAX_NUM_BUSSES. Use > a fixed-length array and an assert instead. > > Signed-off-by: Peter Maydell Reviewed-by: Alistair Franci

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-28 Thread Francisco Iglesias
On [2019 Mar 28] Thu 15:26:35, Peter Maydell wrote: > In the stripe8() function we use a variable length array; however > we know that the maximum length required is MAX_NUM_BUSSES. Use > a fixed-length array and an assert instead. > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias

Re: [Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-28 Thread Edgar E. Iglesias
+ Francisco On Thu, 28 Mar. 2019, 16:26 Peter Maydell, wrote: > In the stripe8() function we use a variable length array; however > we know that the maximum length required is MAX_NUM_BUSSES. Use > a fixed-length array and an assert instead. > > Signed-off-by: Peter Maydell > --- > hw/ssi/xili

[Qemu-devel] [PATCH for-4.1] hw/ssi/xilinx_spips: Avoid variable length array

2019-03-28 Thread Peter Maydell
In the stripe8() function we use a variable length array; however we know that the maximum length required is MAX_NUM_BUSSES. Use a fixed-length array and an assert instead. Signed-off-by: Peter Maydell --- hw/ssi/xilinx_spips.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff -