Re: [Qemu-devel] [PATCH for-4.1 4/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 6:51 AM, Thomas Huth wrote: > On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: >> ISA Super I/O are already modeled by the ISASuperIODevice abstract >> device. >> Since this board uses a generic ISA Super I/O chipset, refactor it >> as the TYPE_R4K_SUPERIO device, child of

Re: [Qemu-devel] [PATCH for-4.1 4/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-04 Thread Thomas Huth
On 05/04/2019 00.12, Philippe Mathieu-Daudé wrote: > ISA Super I/O are already modeled by the ISASuperIODevice abstract > device. > Since this board uses a generic ISA Super I/O chipset, refactor it > as the TYPE_R4K_SUPERIO device, child of ISASuperIODevice. Good idea! > Signed-off-by: Philippe

[Qemu-devel] [PATCH for-4.1 4/4] hw/mips/r4k: Refactor the Super I/O chipset

2019-04-04 Thread Philippe Mathieu-Daudé
ISA Super I/O are already modeled by the ISASuperIODevice abstract device. Since this board uses a generic ISA Super I/O chipset, refactor it as the TYPE_R4K_SUPERIO device, child of ISASuperIODevice. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_r4k.c | 61