Re: [Qemu-devel] [PATCH for-4.1 v2] nbd: Initialize reply on failure

2019-07-22 Thread Andrey Shinkevich
On 19/07/2019 20:20, Eric Blake wrote: > We've had two separate reports of different callers running into use > of uninitialized data if s->quit is set (one detected by gcc -O3, > another by valgrind), due to checking 'nbd_reply_is_simple(reply) || > s->quit' in the wrong order. Rather than chasi

Re: [Qemu-devel] [PATCH for-4.1 v2] nbd: Initialize reply on failure

2019-07-19 Thread Philippe Mathieu-Daudé
On 7/19/19 7:20 PM, Eric Blake wrote: > We've had two separate reports of different callers running into use > of uninitialized data if s->quit is set (one detected by gcc -O3, > another by valgrind), due to checking 'nbd_reply_is_simple(reply) || > s->quit' in the wrong order. Rather than chasing

[Qemu-devel] [PATCH for-4.1 v2] nbd: Initialize reply on failure

2019-07-19 Thread Eric Blake
We've had two separate reports of different callers running into use of uninitialized data if s->quit is set (one detected by gcc -O3, another by valgrind), due to checking 'nbd_reply_is_simple(reply) || s->quit' in the wrong order. Rather than chasing down which callers need to pre-initialize repl