Re: [Qemu-devel] [PATCH for-4.2 14/14] icount: clean up cpu_can_io before jumping to the next block

2019-07-24 Thread Paolo Bonzini
On 25/07/19 07:55, Pavel Dovgalyuk wrote: >> >> I think you do not need this patch if you remove the assignment in >> cpu_tb_exec, and compile a "move 0 to cpu->can_do_io" in gen_tb_start >> instead. > "move 0 to cpu->can_do_io" only for icount mode? Yes, using CF_ICOUNT. > And we'll also need to

Re: [Qemu-devel] [PATCH for-4.2 14/14] icount: clean up cpu_can_io before jumping to the next block

2019-07-24 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 24/07/19 10:44, Pavel Dovgalyuk wrote: > > From: Pavel Dovgalyuk > > > > Most of IO instructions can be executed only at the end of the block in > > icount mode. Therefore translator can set cpu_can_io flag when translating > > the last instr

[Qemu-devel] [PATCH for-4.2 14/14] icount: clean up cpu_can_io before jumping to the next block

2019-07-24 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the ne