Re: [Qemu-devel] [PATCH for-4.2 v3 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread David Hildenbrand
On 02.08.19 15:41, Christian Borntraeger wrote: > > > On 02.08.19 15:36, David Hildenbrand wrote: >> On 02.08.19 15:32, Igor Mammedov wrote: >>> s390 was trying to solve limited KVM memslot size issue by abusing >>> memory_region_allocate_system_memory(), which breaks API contract >>> where the

Re: [Qemu-devel] [PATCH for-4.2 v3 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread Christian Borntraeger
On 02.08.19 15:36, David Hildenbrand wrote: > On 02.08.19 15:32, Igor Mammedov wrote: >> s390 was trying to solve limited KVM memslot size issue by abusing >> memory_region_allocate_system_memory(), which breaks API contract >> where the function might be called only once. >> >> Beside an

Re: [Qemu-devel] [PATCH for-4.2 v3 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread David Hildenbrand
On 02.08.19 15:32, Igor Mammedov wrote: > s390 was trying to solve limited KVM memslot size issue by abusing > memory_region_allocate_system_memory(), which breaks API contract > where the function might be called only once. > > Beside an invalid use of API, the approach also introduced migration

[Qemu-devel] [PATCH for-4.2 v3 2/2] s390: do not call memory_region_allocate_system_memory() multiple times

2019-08-02 Thread Igor Mammedov
s390 was trying to solve limited KVM memslot size issue by abusing memory_region_allocate_system_memory(), which breaks API contract where the function might be called only once. Beside an invalid use of API, the approach also introduced migration issue, since RAM chunks for each