Re: [Qemu-devel] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings)

2013-11-18 Thread Stefan Weil
Please note that this patch fixes real bugs, namely wrong format strings. As far as I could see those bugs are only in code branches which handle rare error conditions, so maybe they only have a low priority. Nevertheless they can be fixed in QEMU 1.7. Do we need a pull request, or can it be appl

[Qemu-devel] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings)

2013-11-17 Thread Stefan Weil
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra): CCqga/commands.o qga/commands.c: In function ‘slog’: qga/commands.c:28:5: error: function might be possible candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] g_logv("syslog", G_LOG_L