On 07/25/2017 09:34 AM, Gerd Hoffmann wrote:
case CMD_GET_OBJECT_INFO:
-o = usb_mtp_object_lookup(s, c->argv[0]);
+if (c->argc > 0) {
+o = usb_mtp_object_lookup(s, c->argv[0]);
+}
How about zero-initializing c->argv instead?
I checked the MTP specs r
case CMD_GET_OBJECT_INFO:
> -o = usb_mtp_object_lookup(s, c->argv[0]);
> +if (c->argc > 0) {
> +o = usb_mtp_object_lookup(s, c->argv[0]);
> +}
How about zero-initializing c->argv instead?
cheers,
Gerd
hw/usb/dev-mtp.c:1212:13: warning: 2nd function call argument is an
uninitialized value
o = usb_mtp_object_lookup(s, c->argv[0]);
^~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/dev-mtp.c | 16 +
