Re: [Qemu-devel] [PATCH for 2.4 2/3] net/dp8393x: specify memory operations for PROM PROM

2015-07-27 Thread Paolo Bonzini
On 26/07/2015 22:35, Hervé Poussineau wrote: > +memory_region_init_ram(&s->prom, OBJECT(dev), > + "dp8393x-prom", SONIC_PROM_SIZE, &local_err); > +if (local_err) { > +error_propagate(errp, local_err); > +return; > +} > +memory_region_set_r

Re: [Qemu-devel] [PATCH for 2.4 2/3] net/dp8393x: specify memory operations for PROM PROM

2015-07-26 Thread Aurelien Jarno
On 2015-07-26 22:35, Hervé Poussineau wrote: > >How does it crashes in that case? I would have guess that write access > >to ROM are ignored by default. Looking at other code, it seems they call > >memory_region_set_readonly() instead of providing an accepts function. > >Maybe readonly should be th

Re: [Qemu-devel] [PATCH for 2.4 2/3] net/dp8393x: specify memory operations for PROM PROM

2015-07-26 Thread Hervé Poussineau
Hi, Le 26/07/2015 22:11, Aurelien Jarno a écrit : On 2015-07-24 20:42, Hervé Poussineau wrote: This fixes a guest-triggerable QEMU crash when guest tries to write to PROM. Signed-off-by: Hervé Poussineau --- hw/net/dp8393x.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-

Re: [Qemu-devel] [PATCH for 2.4 2/3] net/dp8393x: specify memory operations for PROM PROM

2015-07-26 Thread Aurelien Jarno
On 2015-07-24 20:42, Hervé Poussineau wrote: > This fixes a guest-triggerable QEMU crash when guest tries to write to PROM. > > Signed-off-by: Hervé Poussineau > --- > hw/net/dp8393x.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/hw/net/dp8393x.c b/hw/ne

[Qemu-devel] [PATCH for 2.4 2/3] net/dp8393x: specify memory operations for PROM PROM

2015-07-24 Thread Hervé Poussineau
This fixes a guest-triggerable QEMU crash when guest tries to write to PROM. Signed-off-by: Hervé Poussineau --- hw/net/dp8393x.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 8fafdb0..55168b5 100644 --- a/hw/net/dp8393