Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-28 Thread Palmer Dabbelt
On Thu, 28 Mar 2019 10:34:08 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 27, 2019 at 8:15 PM Palmer Dabbelt wrote: On Wed, 27 Mar 2019 09:29:56 PDT (-0700), alistai...@gmail.com wrote: > On Wed, Mar 27, 2019 at 3:29 AM Palmer Dabbelt wrote: >> >> On Wed, 20 Mar 2019 17:46:09 PDT (-07

Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-28 Thread Alistair Francis
On Wed, Mar 27, 2019 at 8:15 PM Palmer Dabbelt wrote: > > On Wed, 27 Mar 2019 09:29:56 PDT (-0700), alistai...@gmail.com wrote: > > On Wed, Mar 27, 2019 at 3:29 AM Palmer Dabbelt wrote: > >> > >> On Wed, 20 Mar 2019 17:46:09 PDT (-0700), Alistair Francis wrote: > >> > The irq is incorrectly calcu

Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-27 Thread Palmer Dabbelt
On Wed, 27 Mar 2019 09:29:56 PDT (-0700), alistai...@gmail.com wrote: On Wed, Mar 27, 2019 at 3:29 AM Palmer Dabbelt wrote: On Wed, 20 Mar 2019 17:46:09 PDT (-0700), Alistair Francis wrote: > The irq is incorrectly calculated to be off by one. It has worked in the > past as the priority_base o

Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-27 Thread Alistair Francis
On Wed, Mar 27, 2019 at 3:29 AM Palmer Dabbelt wrote: > > On Wed, 20 Mar 2019 17:46:09 PDT (-0700), Alistair Francis wrote: > > The irq is incorrectly calculated to be off by one. It has worked in the > > past as the priority_base offset has also been set incorrectly. We are > > about to fix the p

Re: [Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-27 Thread Palmer Dabbelt
On Wed, 20 Mar 2019 17:46:09 PDT (-0700), Alistair Francis wrote: The irq is incorrectly calculated to be off by one. It has worked in the past as the priority_base offset has also been set incorrectly. We are about to fix the priority_base offset so first first the irq calculation. Signed-off-b

[Qemu-devel] [PATCH for 4.0 v1 1/5] riscv: plic: Fix incorrect irq calculation

2019-03-20 Thread Alistair Francis
The irq is incorrectly calculated to be off by one. It has worked in the past as the priority_base offset has also been set incorrectly. We are about to fix the priority_base offset so first first the irq calculation. Signed-off-by: Alistair Francis --- hw/riscv/sifive_plic.c | 4 ++-- 1 file ch