Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-15 Thread Alexey Kardashevskiy
On 16/5/18 12:30 am, Eric Blake wrote: > On 05/14/2018 02:00 AM, Alexey Kardashevskiy wrote: >> On 13/3/18 6:44 pm, Samuel Thibault wrote: >>> Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: Signed-off-by: Alexey Kardashevskiy >>> >>> Applied to my tree, thanks! >> >> >> And

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-15 Thread Eric Blake
On 05/14/2018 02:00 AM, Alexey Kardashevskiy wrote: On 13/3/18 6:44 pm, Samuel Thibault wrote: Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: Signed-off-by: Alexey Kardashevskiy Applied to my tree, thanks! And what is your tree, is this something to be merged sometime l

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-14 Thread Samuel Thibault
Alexey Kardashevskiy, le lun. 14 mai 2018 17:00:08 +1000, a ecrit: > On 13/3/18 6:44 pm, Samuel Thibault wrote: > > Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: > >> Signed-off-by: Alexey Kardashevskiy > > > > Applied to my tree, thanks! > > > And what is your tree, is this

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-05-14 Thread Alexey Kardashevskiy
On 13/3/18 6:44 pm, Samuel Thibault wrote: > Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: >> Signed-off-by: Alexey Kardashevskiy > > Applied to my tree, thanks! And what is your tree, is this something to be merged sometime later somewhere? :) > >> --- >> >> checkpatch.

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-13 Thread Eric Blake
On 03/12/2018 11:49 PM, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy --- checkpatch.pl complains on every single changed line as it keeps using tabs - do I need to post 's/\t//g'? No. checkpatch.pl is guidance, but even stronger is 'be consistent to what you are editin

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180313044944.21058-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-13 Thread Samuel Thibault
Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote: > Signed-off-by: Alexey Kardashevskiy Applied to my tree, thanks! > --- > > checkpatch.pl complains on every single changed line as it keeps > using tabs - do I need to post 's/\t//g'? > > --- > Changes: > v2: > * replaced s

[Qemu-devel] [PATCH qemu v2] slirp/debug: Print IP addresses in human readable form

2018-03-12 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy --- checkpatch.pl complains on every single changed line as it keeps using tabs - do I need to post 's/\t//g'? --- Changes: v2: * replaced static cast to (in_addr*) with temporary structs --- slirp/arp_table.c | 4 ++-- slirp/socket.c| 8 sli