Re: [Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-05-30 Thread Paolo Bonzini
On 30/05/2018 06:57, Alexey Kardashevskiy wrote: > hw/intc/apic_common.c|489| object_property_add(obj, "id", "uint32", > hw/ppc/spapr_drc.c|557| object_property_add_uint32_ptr(obj, "id", &drc->id, > NULL); > > This does not look like "remove the "id" property altogether" :) Does this > mean we sti

Re: [Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-05-29 Thread Alexey Kardashevskiy
On 3/5/18 3:40 pm, Alexey Kardashevskiy wrote: > On 30/4/18 7:53 pm, Paolo Bonzini wrote: >> On 30/04/2018 08:25, Alexey Kardashevskiy wrote: >>> +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, >>> TYPE_DEVICE); >>> +const char *id = object_property_print(obj, "id", true, NULL

Re: [Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-05-02 Thread Alexey Kardashevskiy
On 30/4/18 7:53 pm, Paolo Bonzini wrote: > On 30/04/2018 08:25, Alexey Kardashevskiy wrote: >> +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, >> TYPE_DEVICE); >> +const char *id = object_property_print(obj, "id", true, NULL); > > The only objects that have an "id" property a

Re: [Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 08:25, Alexey Kardashevskiy wrote: > +DeviceState *dev = (DeviceState *) object_dynamic_cast(obj, TYPE_DEVICE); > +const char *id = object_property_print(obj, "id", true, NULL); The only objects that have an "id" property are memdevs. If you want to special case their printi

[Qemu-devel] [PATCH qemu v2 1/2] memory/hmp: Print owners/parents in "info mtree"

2018-04-29 Thread Alexey Kardashevskiy
This adds owners/parents (which are the same, just occasionally owner==NULL) printing for memory regions; a new '-o' flag enabled new output. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * cleanups --- include/exec/memory.h | 2 +- memory.c | 69