Re: [Qemu-devel] [PATCH qemu v2 2/4] vfio/spapr: Rename local systempagesize variable

2019-02-14 Thread Alexey Kardashevskiy
On 15/02/2019 14:57, David Gibson wrote: > On Fri, Feb 15, 2019 at 02:37:55PM +1100, Alexey Kardashevskiy wrote: >> >> >> On 15/02/2019 14:32, David Gibson wrote: >>> On Thu, Feb 14, 2019 at 04:21:42PM +1100, Alexey Kardashevskiy wrote: The "systempagesize" name suggests that it is the

Re: [Qemu-devel] [PATCH qemu v2 2/4] vfio/spapr: Rename local systempagesize variable

2019-02-14 Thread David Gibson
On Fri, Feb 15, 2019 at 02:37:55PM +1100, Alexey Kardashevskiy wrote: > > > On 15/02/2019 14:32, David Gibson wrote: > > On Thu, Feb 14, 2019 at 04:21:42PM +1100, Alexey Kardashevskiy wrote: > >> The "systempagesize" name suggests that it is the host system page size > >> while it is the

Re: [Qemu-devel] [PATCH qemu v2 2/4] vfio/spapr: Rename local systempagesize variable

2019-02-14 Thread David Gibson
On Thu, Feb 14, 2019 at 04:21:42PM +1100, Alexey Kardashevskiy wrote: > The "systempagesize" name suggests that it is the host system page size > while it is the smallest page size of memory backing the guest RAM so > let's rename it to stop confusion. This should cause no behavioral change. > >

Re: [Qemu-devel] [PATCH qemu v2 2/4] vfio/spapr: Rename local systempagesize variable

2019-02-14 Thread Alexey Kardashevskiy
On 15/02/2019 14:32, David Gibson wrote: > On Thu, Feb 14, 2019 at 04:21:42PM +1100, Alexey Kardashevskiy wrote: >> The "systempagesize" name suggests that it is the host system page size >> while it is the smallest page size of memory backing the guest RAM so >> let's rename it to stop

[Qemu-devel] [PATCH qemu v2 2/4] vfio/spapr: Rename local systempagesize variable

2019-02-13 Thread Alexey Kardashevskiy
The "systempagesize" name suggests that it is the host system page size while it is the smallest page size of memory backing the guest RAM so let's rename it to stop confusion. This should cause no behavioral change. Signed-off-by: Alexey Kardashevskiy --- hw/vfio/spapr.c | 6 +++--- 1 file