Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use

2017-10-18 Thread Michael S. Tsirkin
On Tue, Oct 17, 2017 at 04:00:05PM +1100, Alexey Kardashevskiy wrote: > On 15/10/17 19:01, Peter Xu wrote: > > On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote: > >> This moves pci_dev->name initialization earlier so > >> pci_dev->bus_master_as could get a name instead of an emp

Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use

2017-10-16 Thread Alexey Kardashevskiy
On 15/10/17 19:01, Peter Xu wrote: > On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote: >> This moves pci_dev->name initialization earlier so >> pci_dev->bus_master_as could get a name instead of an empty string. > > Or use "name" instead of "pci_dev->name" when do address_space

Re: [Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use

2017-10-15 Thread Peter Xu
On Sun, Oct 15, 2017 at 03:24:52PM +1100, Alexey Kardashevskiy wrote: > This moves pci_dev->name initialization earlier so > pci_dev->bus_master_as could get a name instead of an empty string. Or use "name" instead of "pci_dev->name" when do address_space_init()? But I think this one works too. >

[Qemu-devel] [PATCH qemu v2 REPOST] pci: Initialize pci_dev->name before use

2017-10-14 Thread Alexey Kardashevskiy
This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of an empty string. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * fixed mistype in the commit log * added "rb" --- hw/pci/pci.c | 2 +- 1 file change