Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-17 Thread Jan Kiszka
On 2012-10-16 18:02, Andreas Färber wrote: > Am 12.10.2012 03:26, schrieb Andreas Färber: >> This prepares for changing the variable type from void*. >> >> Signed-off-by: Andreas Färber >> Cc: Igor Mammedov > > Paolo, are you happy with getting rid of the pointer property this way? > > Jan, are

Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-16 Thread Paolo Bonzini
Il 16/10/2012 18:02, Andreas Färber ha scritto: > Am 12.10.2012 03:26, schrieb Andreas Färber: >> This prepares for changing the variable type from void*. >> >> Signed-off-by: Andreas Färber >> Cc: Igor Mammedov > > Paolo, are you happy with getting rid of the pointer property this way? I would

Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-16 Thread Andreas Färber
Am 12.10.2012 03:26, schrieb Andreas Färber: > This prepares for changing the variable type from void*. > > Signed-off-by: Andreas Färber > Cc: Igor Mammedov Paolo, are you happy with getting rid of the pointer property this way? Jan, are you okay with accessing APICCommonState in target-i386/

Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-15 Thread Igor Mammedov
On Fri, 12 Oct 2012 03:26:37 +0200 Andreas Färber wrote: > This prepares for changing the variable type from void*. > > Signed-off-by: Andreas Färber > Cc: Igor Mammedov > --- > hw/apic_common.c |1 - > target-i386/cpu.c |5 - > 2 Dateien geändert, 4 Zeilen hinzugefügt(+), 2 Zeil

[Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-11 Thread Andreas Färber
This prepares for changing the variable type from void*. Signed-off-by: Andreas Färber Cc: Igor Mammedov --- hw/apic_common.c |1 - target-i386/cpu.c |5 - 2 Dateien geändert, 4 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/apic_common.c b/hw/apic_common.c index 371f