Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-07-18 Thread Andreas Färber
Am 15.07.2013 17:29, schrieb Paolo Bonzini: > Il 15/07/2013 17:20, Andreas Färber ha scritto: >> We have some ugly include chains - yes, it shouldn't be here forever. >> Just like the qemu/log.h situation is pretty unsatisfactory (I wouldve >> liked to place log_cpu_state() into qom/cpu.h but it de

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-07-15 Thread Paolo Bonzini
Il 15/07/2013 17:20, Andreas Färber ha scritto: > We have some ugly include chains - yes, it shouldn't be here forever. > Just like the qemu/log.h situation is pretty unsatisfactory (I wouldve > liked to place log_cpu_state() into qom/cpu.h but it depends in > qemu-common.h and even ignoring that d

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-07-15 Thread Andreas Färber
Am 15.07.2013 16:56, schrieb Paolo Bonzini: > Il 16/06/2013 17:57, Andreas Färber ha scritto: >> Move it to qom/cpu.h. > > Hmm, why move it to qom/cpu.h? Isn't it an implementation detail that > there is a current CPU? We have some ugly include chains - yes, it shouldn't be here forever. Just li

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-07-15 Thread Paolo Bonzini
Il 16/06/2013 17:57, Andreas Färber ha scritto: > Move it to qom/cpu.h. Hmm, why move it to qom/cpu.h? Isn't it an implementation detail that there is a current CPU? Paolo > Signed-off-by: Andreas Färber > --- > cpu-exec.c | 13 +++-- > cpus.c | 29 ++

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-21 Thread Andreas Färber
Am 17.06.2013 22:40, schrieb Richard Henderson: > On 06/16/2013 08:57 AM, Andreas Färber wrote: >> diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c >> index 207dcad..f0b1f6f 100644 >> --- a/hw/alpha/typhoon.c >> +++ b/hw/alpha/typhoon.c >> @@ -72,9 +72,8 @@ static void cpu_irq_change(AlphaCPU *

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-19 Thread Paolo Bonzini
Il 18/06/2013 18:52, Andreas Färber ha scritto: > Am 16.06.2013 22:49, schrieb Blue Swirl: >> On Sun, Jun 16, 2013 at 3:57 PM, Andreas Färber wrote: >>> Move it to qom/cpu.h. >> >> While renaming, perhaps a more descriptive name could be used instead >> of 'cpu_single_cpu', something like cpu_loop

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-18 Thread Andreas Färber
Am 16.06.2013 22:49, schrieb Blue Swirl: > On Sun, Jun 16, 2013 at 3:57 PM, Andreas Färber wrote: >> Move it to qom/cpu.h. > > While renaming, perhaps a more descriptive name could be used instead > of 'cpu_single_cpu', something like cpu_loop_current_cpu? There were some local variables named c

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-17 Thread Richard Henderson
On 06/16/2013 08:57 AM, Andreas Färber wrote: > diff --git a/hw/alpha/typhoon.c b/hw/alpha/typhoon.c > index 207dcad..f0b1f6f 100644 > --- a/hw/alpha/typhoon.c > +++ b/hw/alpha/typhoon.c > @@ -72,9 +72,8 @@ static void cpu_irq_change(AlphaCPU *cpu, uint64_t req) > > static uint64_t cchip_read(vo

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-16 Thread Blue Swirl
On Sun, Jun 16, 2013 at 3:57 PM, Andreas Färber wrote: > Move it to qom/cpu.h. While renaming, perhaps a more descriptive name could be used instead of 'cpu_single_cpu', something like cpu_loop_current_cpu? > > Signed-off-by: Andreas Färber > --- > cpu-exec.c | 13 +++-- >

[Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-16 Thread Andreas Färber
Move it to qom/cpu.h. Signed-off-by: Andreas Färber --- cpu-exec.c | 13 +++-- cpus.c | 29 ++--- exec.c | 12 +++- hw/alpha/typhoon.c | 16 hw/arm/pxa2xx.c | 3 +-- hw/i386/kvmv