Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-25 Thread Andreas Färber
Am 25.06.2015 um 13:21 schrieb Peter Maydell: > On 25 June 2015 at 12:12, Andreas Färber wrote: >> Am 24.06.2015 um 21:11 schrieb Peter Maydell: >>> On 24 June 2015 at 19:09, Andreas Färber wrote: +g_assert(cc->set_pc != NULL); +cc->set_pc(cpu, addr); } >>> >>> Do we need

Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-25 Thread Peter Maydell
On 25 June 2015 at 12:12, Andreas Färber wrote: > Am 24.06.2015 um 21:11 schrieb Peter Maydell: >> On 24 June 2015 at 19:09, Andreas Färber wrote: >>> +g_assert(cc->set_pc != NULL); >>> +cc->set_pc(cpu, addr); >>> } >> >> Do we need this assert? If it would have fired >> then we'll just

Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-25 Thread Andreas Färber
Am 24.06.2015 um 21:11 schrieb Peter Maydell: > On 24 June 2015 at 19:09, Andreas Färber wrote: >> s/set-pc/set_pc/ >> >> Am 24.06.2015 um 05:19 schrieb Peter Crosthwaite: >>> Add a wrapper around the CPUClass::set_pc() hook. >>> >>> Signed-off-by: Peter Crosthwaite >>> --- >>> changed since v2:

Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-24 Thread Peter Maydell
On 24 June 2015 at 19:09, Andreas Färber wrote: > s/set-pc/set_pc/ > > Am 24.06.2015 um 05:19 schrieb Peter Crosthwaite: >> Add a wrapper around the CPUClass::set_pc() hook. >> >> Signed-off-by: Peter Crosthwaite >> --- >> changed since v2: >> drop "qom" from commit message subject. >> Add () to

Re: [Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-24 Thread Andreas Färber
s/set-pc/set_pc/ Am 24.06.2015 um 05:19 schrieb Peter Crosthwaite: > Add a wrapper around the CPUClass::set_pc() hook. > > Signed-off-by: Peter Crosthwaite > --- > changed since v2: > drop "qom" from commit message subject. > Add () to functions in commit messages. > Drop error argument > --- >

[Qemu-devel] [PATCH qom v3 1/4] cpu: Add wrapper to the set-pc() hook

2015-06-23 Thread Peter Crosthwaite
Add a wrapper around the CPUClass::set_pc() hook. Signed-off-by: Peter Crosthwaite --- changed since v2: drop "qom" from commit message subject. Add () to functions in commit messages. Drop error argument --- include/qom/cpu.h | 17 + 1 file changed, 17 insertions(+) diff --git