Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-04-03 Thread Daniel P. Berrange
On Tue, Mar 21, 2017 at 10:25:31AM +0100, Pradeep Jagadeesh wrote: > > On 3/20/2017 2:17 PM, Daniel P. Berrange wrote: > > On Mon, Mar 20, 2017 at 09:07:20AM -0400, Pradeep Jagadeesh wrote: > > > > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > > index 8819281..e4e3478 100644 > > > ---

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-23 Thread Pradeep Jagadeesh
On 3/21/2017 1:06 PM, Greg Kurz wrote: On Tue, 21 Mar 2017 10:44:32 +0100 Pradeep Jagadeesh wrote: Hi Eric, Thanks for having a look at the patch. My answers are inline. On 03/20/2017 08:07 AM, Pradeep Jagadeesh wrote: This patchset enables qmp interfaces for

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-22 Thread Pradeep Jagadeesh
On 3/21/2017 2:38 PM, Greg Kurz wrote: On Mon, 20 Mar 2017 09:07:20 -0400 Pradeep Jagadeesh wrote: This patchset enables qmp interfaces for the 9pfs devices (fsdev).This provides two interfaces one for querying all the 9pfs devices info. The second one to set the IO

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-21 Thread Eric Blake
On 03/21/2017 04:44 AM, Pradeep Jagadeesh wrote: >> >> You're introducing this struct in 2.10, so this member is not since 1.7. >> Either that, or you're copying-and-pasting when you should be sharing >> code and reusing an existing struct. > Hmm..copied the block devices code, I will correct

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-21 Thread Greg Kurz
On Mon, 20 Mar 2017 09:07:20 -0400 Pradeep Jagadeesh wrote: > This patchset enables qmp interfaces for the 9pfs > devices (fsdev).This provides two interfaces one > for querying all the 9pfs devices info. The second one > to set the IO limits for the required 9pfs

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-21 Thread Greg Kurz
On Tue, 21 Mar 2017 10:44:32 +0100 Pradeep Jagadeesh wrote: > Hi Eric, > > Thanks for having a look at the patch. My answers are inline. > > > On 03/20/2017 08:07 AM, Pradeep Jagadeesh wrote: > >> This patchset enables qmp interfaces for the 9pfs > >> devices

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-21 Thread Pradeep Jagadeesh
Hi Eric, Thanks for having a look at the patch. My answers are inline. On 03/20/2017 08:07 AM, Pradeep Jagadeesh wrote: This patchset enables qmp interfaces for the 9pfs devices (fsdev).This provides two interfaces one Space between English sentences, after '.' OK for querying all the

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-21 Thread Pradeep Jagadeesh
On 3/20/2017 2:17 PM, Daniel P. Berrange wrote: On Mon, Mar 20, 2017 at 09:07:20AM -0400, Pradeep Jagadeesh wrote: diff --git a/hmp-commands.hx b/hmp-commands.hx index 8819281..e4e3478 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1637,6 +1637,34 @@ ETEXI }, STEXI +@item

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-20 Thread Eric Blake
On 03/20/2017 08:07 AM, Pradeep Jagadeesh wrote: > This patchset enables qmp interfaces for the 9pfs > devices (fsdev).This provides two interfaces one Space between English sentences, after '.' > for querying all the 9pfs devices info. The second one > to set the IO limits for the required

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-20 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Subject: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling Message-id: 1490015240-49118-1-git-send-email-pradeep.jagade...@huawei.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script

Re: [Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-20 Thread Daniel P. Berrange
On Mon, Mar 20, 2017 at 09:07:20AM -0400, Pradeep Jagadeesh wrote: > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 8819281..e4e3478 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -1637,6 +1637,34 @@ ETEXI > }, > > STEXI > +@item 9p_passwd @var{device} @var{password}

[Qemu-devel] [PATCH v0] fsdev: QMP interface for throttling

2017-03-20 Thread Pradeep Jagadeesh
This patchset enables qmp interfaces for the 9pfs devices (fsdev).This provides two interfaces one for querying all the 9pfs devices info. The second one to set the IO limits for the required 9pfs device. Signed-off-by: Pradeep Jagadeesh --- Makefile