Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-22 Thread Igor Mammedov
On Thu, 22 Jan 2015 20:04:46 +0530 Bharata B Rao wrote: [...] > If you find the below patch to be fine, I will repost the series > with this patch included. Looks fine to me > > pc-dimm: Add Error argument to pc_existing_dimms_capacity > > From: Bharata B Rao > > Now that pc_existing_dimms

Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-22 Thread Bharata B Rao
On Wed, Jan 21, 2015 at 11:38:52AM +0100, Igor Mammedov wrote: > On Wed, 21 Jan 2015 14:28:18 +0530 > > > > +int pc_existing_dimms_capacity(Object *obj, void *opaque) > > > > +{ > > > since you are making it API, could you pass Error **errp argument > > > and deal with error in caller? > > > Along

Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-21 Thread Igor Mammedov
On Wed, 21 Jan 2015 14:28:18 +0530 Bharata B Rao wrote: > On Tue, Jan 20, 2015 at 11:18:37AM +0100, Igor Mammedov wrote: > > On Mon, 12 Jan 2015 09:32:34 +0530 > > Bharata B Rao wrote: > > > > > Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed > > > by PowerPC memory hotp

Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-21 Thread Bharata B Rao
On Tue, Jan 20, 2015 at 11:18:37AM +0100, Igor Mammedov wrote: > On Mon, 12 Jan 2015 09:32:34 +0530 > Bharata B Rao wrote: > > > Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed > > by PowerPC memory hotplug code too. > > > > Signed-off-by: Bharata B Rao > > --- > > hw/i

Re: [Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-20 Thread Igor Mammedov
On Mon, 12 Jan 2015 09:32:34 +0530 Bharata B Rao wrote: > Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed > by PowerPC memory hotplug code too. > > Signed-off-by: Bharata B Rao > --- > hw/i386/pc.c | 24 > hw/mem/pc-dimm.c |

[Qemu-devel] [PATCH v0 2/2] pc-dimm: Make pc_existing_dimms_capacity global

2015-01-11 Thread Bharata B Rao
Move pc_existing_dimms_capacity() to pc-dimm.c since it would be needed by PowerPC memory hotplug code too. Signed-off-by: Bharata B Rao --- hw/i386/pc.c | 24 hw/mem/pc-dimm.c | 25 + include/hw/mem/pc-dimm.h | 1 + 3 files c