Re: [Qemu-devel] [PATCH v1] migration: add incremental mode on drive-mirror

2018-12-24 Thread 滴滴云
I redescribe details on cover letter and send a new mail in December 20, 2018. Please help me review again, thank you. 在 2018/12/19 下午10:48,“Eric Blake” 写入: On 12/19/18 12:50 AM, mahaocong wrote: > From: mahaocong > > Signed-off-by: mahaocong The subject line tells

Re: [Qemu-devel] [PATCH v1] migration: add incremental mode on drive-mirror

2018-12-19 Thread Eric Blake
On 12/19/18 12:50 AM, mahaocong wrote: From: mahaocong Signed-off-by: mahaocong The subject line tells "what", but you are missing a commit message body that gives the "why". Details about the new feature, and how it is useful, go a long way to making the code easier to review. How much

[Qemu-devel] [PATCH v1] migration: add incremental mode on drive-mirror

2018-12-18 Thread mahaocong
From: mahaocong Signed-off-by: mahaocong --- block/dirty-bitmap.c | 14 ++ block/mirror.c | 63 +++- blockdev.c | 36 +++-- include/block/block_int.h| 3 ++-

[Qemu-devel] [PATCH v1] migration: add incremental mode on drive-mirror

2018-12-18 Thread mahaocong
From: mahaocong Hi all, This patch adds possibility to start mirroring with specific dirty-bitmap. The use-case is, for live migration with ceph rbd image. 1.create rbd image in ceph cluster, and map nbd device with rbd image. 2.create a new bitmap attached to drive. 3.create a full backup on