Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-22 Thread P J P
+-- On Wed, 21 Nov 2018, Stefan Berger wrote --+ | I audited all functions yesterday and my proposed patches are on the mailing | list. The abort related ones seem most critical but they are all passed values | they can handle. I do not think that an out-of-bounds access can occur with | the curren

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread Stefan Berger
qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator *

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread no-reply
Hi, This series failed docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Message-id: 20181120072239.512-1-ppan...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v1] tpm: check

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread Stefan Berger
On 11/20/18 2:22 AM, P J P wrote: From: Prasad J Pandit While performing mmio device r/w operations, guest could set 'addr' parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 after setting new 'locty' via 'tpm_tis_new_active_locality'. Add check to avoid OOB access. Reported-by

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread Stefan Berger
On 11/20/18 1:06 PM, P J P wrote: Hello Stefan, +-- On Tue, 20 Nov 2018, Stefan Berger wrote --+ | On 11/20/18 2:22 AM, P J P wrote: | > From: Prasad J Pandit | > | > While performing mmio device r/w operations, guest could set 'addr' | > parameter such that 'locty' index exceeds TPM_TIS_NUM

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread P J P
Hello Stefan, Marc, +-- On Tue, 20 Nov 2018, P J P wrote --+ | | On 11/20/18 2:22 AM, P J P wrote: | | > From: Prasad J Pandit | | > While performing mmio device r/w operations, guest could set 'addr' | | > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 | | > after setting n

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-20 Thread P J P
Hello Stefan, +-- On Tue, 20 Nov 2018, Stefan Berger wrote --+ | On 11/20/18 2:22 AM, P J P wrote: | > From: Prasad J Pandit | > | > While performing mmio device r/w operations, guest could set 'addr' | > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 | > after setting new '

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-20 Thread Stefan Berger
On 11/20/18 2:22 AM, P J P wrote: From: Prasad J Pandit While performing mmio device r/w operations, guest could set 'addr' parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 after setting new 'locty' via 'tpm_tis_new_active_locality'. Add check to avoid OOB access. Do you hav

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-20 Thread Marc-André Lureau
Hi On Tue, Nov 20, 2018 at 12:02 PM Marc-André Lureau wrote: > > Hi > > On Tue, Nov 20, 2018 at 11:24 AM P J P wrote: > > > > From: Prasad J Pandit > > > > While performing mmio device r/w operations, guest could set 'addr' > > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-20 Thread Marc-André Lureau
Hi On Tue, Nov 20, 2018 at 11:24 AM P J P wrote: > > From: Prasad J Pandit > > While performing mmio device r/w operations, guest could set 'addr' > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 > after setting new 'locty' via 'tpm_tis_new_active_locality'. > Add check to av

[Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-19 Thread P J P
From: Prasad J Pandit While performing mmio device r/w operations, guest could set 'addr' parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 after setting new 'locty' via 'tpm_tis_new_active_locality'. Add check to avoid OOB access. Reported-by: Cheng Feng Signed-off-by: Prasad