Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-24 Thread Paolo Bonzini
On 24/07/19 14:05, Jing Liu wrote: > > Thanks very much. So would you like me to update the patch with v2 now? Yes, please. Paolo

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-24 Thread Jing Liu
On 7/22/2019 7:50 PM, Paolo Bonzini wrote: On 22/07/19 04:59, Jing Liu wrote: On 7/19/2019 4:10 PM, Paolo Bonzini wrote: On 19/07/19 09:20, Jing Liu wrote: Then CPUID[7,0].EAX is set automatically to 0 or 1 depending on whether BF16 is enabled or not. Could I ask why don't we directly c

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-22 Thread Paolo Bonzini
On 22/07/19 04:59, Jing Liu wrote: > > > On 7/19/2019 4:10 PM, Paolo Bonzini wrote: >> On 19/07/19 09:20, Jing Liu wrote: Then CPUID[7,0].EAX is set automatically to 0 or 1 depending on whether BF16 is enabled or not. >>> >>> Could I ask why don't we directly check BF16 enabling when >>

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-21 Thread Jing Liu
On 7/19/2019 4:10 PM, Paolo Bonzini wrote: On 19/07/19 09:20, Jing Liu wrote: Then CPUID[7,0].EAX is set automatically to 0 or 1 depending on whether BF16 is enabled or not. Could I ask why don't we directly check BF16 enabling when cpu_x86_cpuid(env, 7, 0, ...) during kvm_arch_init_vcpu ?

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-19 Thread Paolo Bonzini
On 19/07/19 09:20, Jing Liu wrote: >> Then CPUID[7,0].EAX is set automatically to 0 or 1 depending on whether >> BF16 is enabled or not. > > Could I ask why don't we directly check BF16 enabling when > cpu_x86_cpuid(env, 7, 0, ...) during kvm_arch_init_vcpu ? Because the code for setting CPUID is

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-19 Thread Jing Liu
On 7/18/2019 4:15 PM, Paolo Bonzini wrote: On 18/07/19 06:55, Jing Liu wrote: +    *eax = kvm_arch_get_supported_cpuid(cs->kvm_state, 0x7, +    count, R_EAX); This needs to be firstly checked as follows, otherwise some architectures would

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-18 Thread Paolo Bonzini
On 18/07/19 06:55, Jing Liu wrote: >> >> +    *eax = kvm_arch_get_supported_cpuid(cs->kvm_state, 0x7, >> +    count, R_EAX); > This needs to be firstly checked as follows, otherwise some > architectures would fail to compile. > > What about hvf a

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-17 Thread Jing Liu
On 7/11/2019 1:38 PM, Jing Liu wrote: Intel CooperLake cpu adds AVX512_BF16 instruction, defining as CPUID.(EAX=7,ECX=1):EAX[bit 05]. The release spec link as follows, https://software.intel.com/sites/default/files/managed/c5/15/\ architecture-instruction-set-extensions-programming-reference.

Re: [Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1562823509-13072-1-git-send-email-jing2@linux.intel.com/ Hi, This series failed build test on s390x host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing

[Qemu-devel] [PATCH v1] x86: Intel AVX512_BF16 feature enabling

2019-07-10 Thread Jing Liu
Intel CooperLake cpu adds AVX512_BF16 instruction, defining as CPUID.(EAX=7,ECX=1):EAX[bit 05]. The release spec link as follows, https://software.intel.com/sites/default/files/managed/c5/15/\ architecture-instruction-set-extensions-programming-reference.pdf Signed-off-by: Jing Liu --- target/i