Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups)

2017-10-16 Thread Joe Clifford
On 16/10/17 17:20, Paolo Bonzini wrote: On 16/10/2017 16:42, David Hildenbrand wrote: Hopefully this is the last bunch of fixes for the cleanup series. 1. log_start() was called before region_add(), which is wrong. 2. I messed up the calculation of the delta when aligning the ram address (m

Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups)

2017-10-16 Thread Paolo Bonzini
On 16/10/2017 16:42, David Hildenbrand wrote: > Hopefully this is the last bunch of fixes for the cleanup series. > > 1. log_start() was called before region_add(), which is wrong. > 2. I messed up the calculation of the delta when aligning the ram address >(maybe we should simply also use ROU

[Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups)

2017-10-16 Thread David Hildenbrand
Hopefully this is the last bunch of fixes for the cleanup series. 1. log_start() was called before region_add(), which is wrong. 2. I messed up the calculation of the delta when aligning the ram address (maybe we should simply also use ROUND_UP there ...). 3. I think we could get log_start/log_