Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-15 Thread Stefan Hajnoczi
On Tue, Jun 14, 2016 at 03:53:48PM -0600, Eric Blake wrote: > On 06/14/2016 06:26 AM, Stefan Hajnoczi wrote: > > On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote: > >> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%) > >> + $(call quiet-command,cat $^ > $@) > >

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-14 Thread Eric Blake
On 06/14/2016 06:26 AM, Stefan Hajnoczi wrote: > On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote: >> +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%) >> +$(call quiet-command,cat $^ > $@) > > $^ needs to be a stable ordering across make invocations and acros

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-14 Thread Stefan Hajnoczi
On Thu, Jun 09, 2016 at 05:57:55PM +0100, Daniel P. Berrange wrote: > +$(BUILD_DIR)/trace-events-all: $(trace-events-y:%=$(SRC_PATH)/%) > + $(call quiet-command,cat $^ > $@) $^ needs to be a stable ordering across make invocations and across machines to avoid thrashing ccache and spuriously re

Re: [Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-09 Thread Gerd Hoffmann
On Do, 2016-06-09 at 17:57 +0100, Daniel P. Berrange wrote: > - $(INSTALL_DATA) $(SRC_PATH)/trace-events > "$(DESTDIR)$(qemu_datadir)/trace-events" > + $(INSTALL_DATA) $(SRC_PATH)/trace-events-all > "$(DESTDIR)$(qemu_datadir)/trace-events" $(BUILD_DIR)/trace-events-all ? cheers, Ger

[Qemu-devel] [PATCH v1 01/40] trace: add build framework for merging trace-events files

2016-06-09 Thread Daniel P. Berrange
Switch make rules over to use trace-events-all as the master trace events input file. Add rule that will construct trace-events-all from $(trace-events-y). Signed-off-by: Daniel P. Berrange --- .gitignore | 1 + Makefile| 2 +- Makefile.objs | 4 Makefile.targe