Re: [Qemu-devel] [PATCH v1 02/17] dataplane: use object pool to speed up allocation for virtio blk request

2014-08-05 Thread Eric Blake
On 08/04/2014 09:33 PM, Ming Lei wrote: g_slice_new(VirtIOBlockReq), its free pair and access the instance Took me a while to read this. Maybe: Calling g_slice_new(VirtIOBlockReq) and its free pair, and accessing the instance, are a bit slow... is a bit slow since sizeof(VirtIOBlockReq)

Re: [Qemu-devel] [PATCH v1 02/17] dataplane: use object pool to speed up allocation for virtio blk request

2014-08-05 Thread Ming Lei
On Tue, Aug 5, 2014 at 8:30 PM, Eric Blake ebl...@redhat.com wrote: On 08/04/2014 09:33 PM, Ming Lei wrote: g_slice_new(VirtIOBlockReq), its free pair and access the instance Took me a while to read this. Maybe: Calling g_slice_new(VirtIOBlockReq) and its free pair, and accessing the

[Qemu-devel] [PATCH v1 02/17] dataplane: use object pool to speed up allocation for virtio blk request

2014-08-04 Thread Ming Lei
g_slice_new(VirtIOBlockReq), its free pair and access the instance is a bit slow since sizeof(VirtIOBlockReq) takes more than 40KB, so use object pool to speed up its allocation and release. With this patch, ~5%-10% throughput improvement is observed in the VM based on server. Signed-off-by: